From owner-svn-src-head@freebsd.org Tue Jul 3 20:06:58 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4BD4D102197A; Tue, 3 Jul 2018 20:06:58 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from smtp-out-so.shaw.ca (smtp-out-so.shaw.ca [64.59.136.139]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 98E0195B8B; Tue, 3 Jul 2018 20:06:57 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from spqr.komquats.com ([70.67.125.17]) by shaw.ca with ESMTPA id aRZefMHjwbP3IaRZgfMENx; Tue, 03 Jul 2018 14:06:56 -0600 X-Authority-Analysis: v=2.3 cv=P64UeBIu c=1 sm=1 tr=0 a=VFtTW3WuZNDh6VkGe7fA3g==:117 a=VFtTW3WuZNDh6VkGe7fA3g==:17 a=kj9zAlcOel0A:10 a=R9QF1RCXAYgA:10 a=6I5d2MoRAAAA:8 a=YxBL1-UpAAAA:8 a=SylrBjB-f8JqxCxX1zgA:9 a=CjuIK1q_8ugA:10 a=IjZwj45LgO3ly-622nXo:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy8 [10.2.2.6]) by spqr.komquats.com (Postfix) with ESMTPS id 7B16276C; Tue, 3 Jul 2018 13:06:54 -0700 (PDT) Received: from slippy.cwsent.com (localhost [127.0.0.1]) by slippy.cwsent.com (8.15.2/8.15.2) with ESMTP id w63K6c1C069214; Tue, 3 Jul 2018 13:06:38 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Received: from slippy (cy@localhost) by slippy.cwsent.com (8.15.2/8.15.2/Submit) with ESMTP id w63K6c3E069211; Tue, 3 Jul 2018 13:06:38 -0700 (PDT) (envelope-from Cy.Schubert@cschubert.com) Message-Id: <201807032006.w63K6c3E069211@slippy.cwsent.com> X-Authentication-Warning: slippy.cwsent.com: cy owned process doing -bs X-Mailer: exmh version 2.8.0 04/21/2012 with nmh-1.7.1 Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Bryan Drewery cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r335908 - head/sys/conf In-Reply-To: Message from Bryan Drewery of "Tue, 03 Jul 2018 20:03:19 -0000." <201807032003.w63K3JD3071764@repo.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Tue, 03 Jul 2018 13:06:38 -0700 X-CMAE-Envelope: MS4wfCBoXa+tTB5ZIY9YQ1MrLo7nPswL9dhAe1nwYRcndVwtrnUOjGH5nhlt7/Ly9vwIfkDIZtCBQaQ/ZkMktjzHimi1wxOpOpoa9S6SCuEurndK9lP+9dzC vhXe33KOWwmK7HBa6huaVA1xX4V3YRsP/34XQYG+xkDuLAoNyPgpokcECdvjNo51DRiP3XSHN9irGqc8D4hFtvQhM9A/nVnCppwPB+90WTMYpp/+yToTih+p 3as/fwgtp7dQnymdgT1jOZ2jBWY9yjEIpqK47ly4ZTBpNUVA5svGXhDAXXZNvxUq X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jul 2018 20:06:58 -0000 In message <201807032003.w63K3JD3071764@repo.freebsd.org>, Bryan Drewery writes : > Author: bdrewery > Date: Tue Jul 3 20:03:19 2018 > New Revision: 335908 > URL: https://svnweb.freebsd.org/changeset/base/335908 > > Log: > Fix r335906+r335907 to not pass multiple source files to genoffset_test.o t > arget. > > This is working around a bug with the FAST_DEPEND logic with custom targets > that use .ALLSRC. > > Reported by: mmacy > > Modified: > head/sys/conf/kern.post.mk > > Modified: head/sys/conf/kern.post.mk > ============================================================================= > = > --- head/sys/conf/kern.post.mk Tue Jul 3 19:24:52 2018 (r33590 > 7) > +++ head/sys/conf/kern.post.mk Tue Jul 3 20:03:19 2018 (r33590 > 8) > @@ -195,8 +195,8 @@ genoffset.o: $S/kern/genoffset.c > # is to exercise the CTASSERT that checks that the offsets in the offset.inc > # _lite struct(s) match those in the original(s). > genoffset_test.o: $S/kern/genoffset.c offset.inc > - ${CC} -c ${CFLAGS:N-flto:N-fno-common} -DOFFSET_TEST ${.ALLSRC:M*.c} \ > - -o ${.TARGET} > + ${CC} -c ${CFLAGS:N-flto:N-fno-common} -DOFFSET_TEST \ > + $S/kern/genoffset.c -o ${.TARGET} This still won't build because of -c and -o. > > assym.inc: $S/kern/genassym.sh genassym.o genoffset_test.o > NM='${NM}' NMFLAGS='${NMFLAGS}' sh $S/kern/genassym.sh genassym.o > ${. > TARGET} > -- Cheers, Cy Schubert FreeBSD UNIX: Web: http://www.FreeBSD.org The need of the many outweighs the greed of the few.