From owner-svn-src-head@FreeBSD.ORG Tue Nov 16 08:43:26 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 18636106564A; Tue, 16 Nov 2010 08:43:26 +0000 (UTC) (envelope-from lstewart@FreeBSD.org) Received: from svn.freebsd.org (svn.freebsd.org [IPv6:2001:4f8:fff6::2c]) by mx1.freebsd.org (Postfix) with ESMTP id 0733F8FC1A; Tue, 16 Nov 2010 08:43:26 +0000 (UTC) Received: from svn.freebsd.org (localhost [127.0.0.1]) by svn.freebsd.org (8.14.3/8.14.3) with ESMTP id oAG8hPci046082; Tue, 16 Nov 2010 08:43:25 GMT (envelope-from lstewart@svn.freebsd.org) Received: (from lstewart@localhost) by svn.freebsd.org (8.14.3/8.14.3/Submit) id oAG8hPCm046080; Tue, 16 Nov 2010 08:43:25 GMT (envelope-from lstewart@svn.freebsd.org) Message-Id: <201011160843.oAG8hPCm046080@svn.freebsd.org> From: Lawrence Stewart Date: Tue, 16 Nov 2010 08:43:25 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org X-SVN-Group: head MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Subject: svn commit: r215393 - head/sys/netinet/cc X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Nov 2010 08:43:26 -0000 Author: lstewart Date: Tue Nov 16 08:43:25 2010 New Revision: 215393 URL: http://svn.freebsd.org/changeset/base/215393 Log: - Querying the default CC algo is more common than setting it and the function is small, so there is no good reason not to declare the buffer at the top. - Fix a whitespace nit. Sponsored by: FreeBSD Foundation MFC after: 11 weeks X-MFC with: r215166 Modified: head/sys/netinet/cc/cc.c Modified: head/sys/netinet/cc/cc.c ============================================================================== --- head/sys/netinet/cc/cc.c Tue Nov 16 08:30:39 2010 (r215392) +++ head/sys/netinet/cc/cc.c Tue Nov 16 08:43:25 2010 (r215393) @@ -106,14 +106,13 @@ cc_set_default(struct cc_algo *new_defau static int cc_default_algo(SYSCTL_HANDLER_ARGS) { + char default_cc[TCP_CA_NAME_MAX]; struct cc_algo *funcs; int err, found; err = found = 0; if (req->newptr == NULL) { - char default_cc[TCP_CA_NAME_MAX]; - /* Just print the current default. */ CC_LIST_RLOCK(); strlcpy(default_cc, CC_DEFAULT()->name, TCP_CA_NAME_MAX); @@ -216,7 +215,7 @@ cc_deregister_algo(struct cc_algo *remov } } CC_LIST_WUNLOCK(); - + if (!err) /* * XXXLAS: