From owner-cvs-sbin  Mon Oct 14 13:56:08 1996
Return-Path: owner-cvs-sbin
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.5/8.7.3) id NAA24977
          for cvs-sbin-outgoing; Mon, 14 Oct 1996 13:56:08 -0700 (PDT)
Received: from irz301.inf.tu-dresden.de (irz301.inf.tu-dresden.de [141.76.1.11])
          by freefall.freebsd.org (8.7.5/8.7.3) with SMTP id NAA24820;
          Mon, 14 Oct 1996 13:52:48 -0700 (PDT)
Received: from sax.sax.de (sax.sax.de [193.175.26.33]) by irz301.inf.tu-dresden.de (8.6.12/8.6.12-s1) with ESMTP id WAA16045; Mon, 14 Oct 1996 22:51:40 +0200
Received: (from uucp@localhost) by sax.sax.de (8.6.12/8.6.12-s1) with UUCP id WAA21036; Mon, 14 Oct 1996 22:51:33 +0200
Received: (from j@localhost) by uriah.heep.sax.de (8.7.6/8.6.9) id WAA07535; Mon, 14 Oct 1996 22:25:24 +0200 (MET DST)
From: J Wunsch <j@uriah.heep.sax.de>
Message-Id: <199610142025.WAA07535@uriah.heep.sax.de>
Subject: Re: cvs commit: src/sbin/savecore savecore.c
To: fenner@parc.xerox.com (Bill Fenner)
Date: Mon, 14 Oct 1996 22:25:24 +0200 (MET DST)
Cc: joerg@freefall.freebsd.org, CVS-committers@freefall.freebsd.org,
        cvs-all@freefall.freebsd.org, cvs-sbin@freefall.freebsd.org
Reply-To: joerg_wunsch@uriah.heep.sax.de (Joerg Wunsch)
In-Reply-To: <96Oct13.144850pdt.177477@crevenia.parc.xerox.com> from Bill Fenner at "Oct 13, 96 02:48:37 pm"
X-Phone: +49-351-2012 669
X-PGP-Fingerprint: DC 47 E6 E4 FF A6 E9 8F  93 21 E0 7D F9 12 D6 4E 
X-Mailer: ELM [version 2.4ME+ PL17 (25)]
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: owner-cvs-sbin@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

As Bill Fenner wrote:

> >  However, he missed the part to compute the kernelsize in kilobytes,
> >  so the minfree consideration was now overcautious.

> Sorry, I thought I had made sure that everything was in K.  Unless I
> missed something, the patch in the PR causes minfree to be specified in
> bytes, which is not what the man page says.

Yep, the patch in the PR broke with the tradition.  My own (not
committed) version also used byte values for everything (with
`dumpsize' also enlarged to off_t), to avoid the implicit truncation
to the lower kilobyte value.  However, i multiplied the value from the
minfree file with 1024 when reading it, in order to comply with the
man page and the historic behaviour.

> In fact, if I re-read my patch, it looks like spacefree and totfree are
> kept in units of K-bytes, kernelsize and dumpsize are kept in units of
> bytes but needed = (dumpsize + kernelsize) / 1024, so needed is in units
> of K-bytes, and minfree is specified in the file as being specified in
> K-bytes.  What am I missing?

Nothing.  I think my brain has already been turned off last night...
Who's got the pointing hat these days?  Pass it on to me! <:-)

-- 
cheers, J"org

joerg_wunsch@uriah.heep.sax.de -- http://www.sax.de/~joerg/ -- NIC: JW11-RIPE
Never trust an operating system you don't have sources for. ;-)