Date: Wed, 15 Nov 2000 13:04:47 -0600 From: "Jeffrey J. Mountin" <jeff-ml@mountin.net> To: Ade Lovett <ade@FreeBSD.ORG>, ports@FreeBSD.ORG Subject: Re: www/apache13-modssl cleanup committed Message-ID: <4.3.2.20001115123227.00c379c0@207.227.119.2> In-Reply-To: <20001115101611.K34578@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--=====================_556243990==_
Content-Type: text/plain; charset="us-ascii"; format=flowed
At 10:16 AM 11/15/00 -0600, Ade Lovett wrote:
>FYI. Thanks to those of you that took the time to try out the
>patches and report back that I hadn't fat-fingered anything :)
>
>Should be on a cvsup server near you in the next few hours,
>you need rev 1.76 of the Makefile.
Looked good here.
Here is a patch that cleans up dead/changed/moved ftp mirrors (same as
PR#22015) and also cleans up the APACHE_PERF_TUNING section, which I sent
you a month back. Here are the points I made then with a few amendments:
apache13-modssl/Makefile
apache13-fp/Makefile
.if defined(APACHE_PERF_TUNING) && ${APACHE_PERF_TUNING} == YES
OPTIM+= -DBUFFERED_LOGS -DFD_SETSIZE=1024
CFLAGS+= -O6 -funroll-loops -fstrength-reduce -fomit-frame-pointer \
-fexpensive-optimizations -ffast-math
apache13-ssl/Makefile
apache13+ipv6/Makefile
apache13-ssl/Makefile
.if defined(APACHE_PERF_TUNING) && ${APACHE_PERF_TUNING} == YES
OPTIM+= -DBUFFERED_LOGS
CFLAGS+= -O6 -fomit-frame-pointer
FD_SETSIZE is no longer needed.
Optimization levels of -O2 and above include -fstrength-reduce and
-fexpensive-optimizations. Not sure how much gain -funroll-loops and
-ffast-math are worth, but they were never used in the apache13 port.
Did some digging and at some point and -fexpensive-optimizations was
dropped with rev 1.60 from apache13. What is interesting are the diffs for
apache13-modssl between rev 1.8 and 1.9, when all the extra flags were
added. Perhaps rse can explain, but just wanted to point out *yet another*
difference.
Technically the -O6 should be -O3 and Dirk mentioned something privately
about changing the flags at some point. Most likely a low-priority or
forgotten to-do, since that was a long time back. <shrug>
----
The patch only removes the redundancies, so there will still be some
differences for the performance tuning section. It may be they were "pet"
optimizations.
Added the performance tuning comment, which was missing.
On a related note. All of the Apache ports should have the mirror site
clean-up. Can file PR's if need be.
--=====================_556243990==_
Content-Type: application/octet-stream; name="apach13-modssl.Makefile.patch"
Content-Transfer-Encoding: x-uuencode
Content-Disposition: attachment; filename="apach13-modssl.Makefile.patch"
begin 600 apach13-modssl.Makefile.patch
M+2TM($UA:V5F:6QE+F]R:6<)5V5D($YO=B`Q-2`Q,3HU,CHP-B`R,#`P"BLK
M*R!-86ME9FEL90E7960@3F]V(#$U(#$R.C4Y.C,Q(#(P,#`*0$`@+3$T+#(W
M("LQ-"PR,B!`0`H@"0EF='`Z+R]F='`N;6]D<W-L+F]R9R]S;W5R8V4O(%P*
M(`D)9G1P.B\O9G1P+G!C82YD9FXN9&4O<'5B+W1O;VQS+VYE="]M;V1?<W-L
M+R!<"BT)"69T<#HO+V9T<"YC8W,N;F5U+F5D=2]N970O;6ER<F]R<R]F='`N
M87!A8VAE+F]R9R]A<&%C:&4O9&ES="\@7`HK"0EF='`Z+R]F='`N8V-S+FYE
M=2YE9'4O;F5T+VUI<G)O<G,O9&5V+F%P86-H92YO<F<O87!A8VAE+V1I<W0O
M(%P*(`D)9G1P.B\O9G1P+G)G92YC;VTO<'5B+VEN9F]S>7-T96US+V%P86-H
M92]D:7-T+R!<"B`)"69T<#HO+V9T<"YE8W)C+FYE="]P=6(O<V5C=7)I='DO
M;6]D7W-S;"\@7`H@"0EF='`Z+R]F='`N;G9G+FYT;G4N;F\O<'5B+W5N:7@O
M;6]D7W-S;"\@7`H@"0EF='`Z+R]A<&%C:&4N8V]M<'5E>"YC;VTO<'5B+V%P
M86-H92]D:7-T+R!<"BT)"69T<#HO+V%P86-H92YA<F-T:6,N;W)G+W!U8B]A
M<&%C:&4O9&ES="\@7`H@"0EF='`Z+R]F='`N=6QP9V,N97,O<'5B+VUO9%]S
M<VPO(%P*(`D)9G1P.B\O9VQO8VLN;6ES<V]U<FDN961U+W!U8B]M;V1?<W-L
M+R!<"B`)"69T<#HO+V9T<"YE<&EX+FYE="]P=6(O87!A8VAE+V1I<W0O(%P*
M+0D)9G1P.B\O9G1P+F%M971H+F]R9R]P=6(O;6ER<F]R<R]F='`N87!A8VAE
M+F]R9R]A<&%C:&4O9&ES="\@7`H@"0EF='`Z+R]F='`N:6YF;W-C:65N8V4N
M8V\N:G`O<'5B+T-R>7!T;R]34TPO;6]D7W-S;"\@7`H@"0EF='`Z+R]F='`N
M=6YI+71R:65R+F1E+W!U8B]U;FEX+W-E8W5R:71Y+VUO9%]S<VPO(%P*+0D)
M9G1P.B\O9G1P+F-O;FYE8W1N970N8V]M+W!U8B]W=W<O87!A8VAE+R!<"B`)
M"69T<#HO+V%P86-H92YT96-H;F]M86YC97(N8V]M+VUI<G)O<G,O87!A8VAE
M+V1I<W0O(%P*(`D)9G1P.B\O9G1P+F)L871Z:&5I;2YC;VTO<'5B+VUO9%]S
M<VPO(%P*(`D)9G1P.B\O9G1P+F9U+6)E<FQI;BYD92]U;FEX+W-E8W5R:71Y
M+VUO9%]S<VPO(%P*(`D)9G1P.B\O9G1P+G)A=F5R+FYE="]P=6(O9G1P+F%P
M86-H92YO<F<O(%P*+0D)9G1P.B\O=W=W,RYS97)V:6-E+F1I9VET86PN8V]M
M+V%P86-H92]D:7-T+R!<"BL)"69T<#HO+W=W=S(N<V5R=FEC92YD:6=I=&%L
M+F-O;2]A<&%C:&4O9&ES="\@7`H@"0EF='`Z+R]F='`N;G1R;"YN970O<'5B
M+VUI<G)O<B]R86QF<W<O;6]D7W-S;"\@7`HM"0EF='`Z+R]G86QI;&5O+F=A
M;&EL96DN8V]M+W!U8B]A<&%C:&4O(%P*+0D)9G1P.B\O9G1P+FUT;G)A;F-H
M+FYE="]P=6(O87!A8VAE+V1I<W0O(%P*(`D)9G1P.B\O9G1P+FEO9'EN86UI
M8W,N8V]M+W!U8B]M:7)R;W(O87!A8VAE+V1I<W0O(%P*+0D)9G1P.B\O87!A
M8VAE+FYE>'1P871H+F-O;2]P=6(O87!A8VAE+V1I<W0O"BL)"69T<#HO+V%P
M86-H92YN97AT<&%T:"YC;VTO<'5B+V%P86-H92\*($1)4U1.04U%/0EA<&%C
M:&5?)'M615)324].7T%004-(17T*($1)4U1&24Q%4ST))'M$25-43D%-17TD
M>T585%)!0U1?4U5&6'T@7`I`0"`M-30L-"`K-#DL."!`0`H@63)+/0D):'1T
M<#HO+W=W=RYM;V1S<VPN;W)G+V1O8W,O,BXW+W-S;%]F87$N:'1M;"-Y,FL*
M(`HK(PHK(R!3970@05!!0TA%7U!%4D9?5%5.24Y'(&5N=BX@=F%R:6%B;&4@
M=&\@6453('1O(&=E="!M87AI;75M('!E<F9O<FUA;F-E"BLC"BL*(%5315]0
M15),-3T)>65S"B!(05-?0T].1DE'55)%/0EY97,*0$`@+3<V+#<@*S<U+#8@
M0$`*(`H@+FEF(&1E9FEN960H05!!0TA%7U!%4D9?5%5.24Y'*2`F)B`D>T%0
M04-(15]015)&7U153DE.1WT@/3T@6453"BU/4%1)32L]"0DM1$)51D9%4D5$
M7TQ/1U,@+41&1%]3151325I%/3$P,C0*+4-&3$%'4RL]"2U/-B`M9G5N<F]L
M;"UL;V]P<R`M9G-T<F5N9W1H+7)E9'5C92`M9F]M:70M9G)A;64M<&]I;G1E
M<B!<"BT)"2UF97AP96YS:79E+6]P=&EM:7IA=&EO;G,@+69F87-T+6UA=&@*
M*T]05$E-*ST)"2U$0E5&1D52141?3$]'4PHK0T9,04=3*ST)+4\V("UF=6YR
M;VQL+6QO;W!S("UF;VUI="UF<F%M92UP;VEN=&5R("UF9F%S="UM871H"B`N
(96YD:68*(`H`
`
end
--=====================_556243990==_
Content-Type: text/plain; charset="us-ascii"; format=flowed
Jeff Mountin - jeff@mountin.net
Systems/Network Administrator
FreeBSD - the power to serve
--=====================_556243990==_--
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4.3.2.20001115123227.00c379c0>