From owner-svn-src-head@FreeBSD.ORG  Sat Dec 27 21:20:02 2008
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 81BAB1065673;
	Sat, 27 Dec 2008 21:20:02 +0000 (UTC)
	(envelope-from ivoras@gmail.com)
Received: from mail-bw0-f19.google.com (mail-bw0-f19.google.com
	[209.85.218.19])
	by mx1.freebsd.org (Postfix) with ESMTP id 5170C8FC0C;
	Sat, 27 Dec 2008 21:20:01 +0000 (UTC)
	(envelope-from ivoras@gmail.com)
Received: by bwz12 with SMTP id 12so11467899bwz.19
	for <multiple recipients>; Sat, 27 Dec 2008 13:19:59 -0800 (PST)
Received: by 10.181.199.11 with SMTP id b11mr3595856bkq.105.1230412798790;
	Sat, 27 Dec 2008 13:19:58 -0800 (PST)
Received: by 10.181.20.7 with HTTP; Sat, 27 Dec 2008 13:19:58 -0800 (PST)
Message-ID: <9bbcef730812271319g60e190acj4a68ee419edc7277@mail.gmail.com>
Date: Sat, 27 Dec 2008 22:19:58 +0100
From: ivoras@freebsd.org
To: "Antoine Brodin" <antoine@freebsd.org>
In-Reply-To: <f19c444a0812270942m39d35ba8teb54943a7f76e@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
References: <200812171957.mBHJvCO2013765@svn.freebsd.org>
	<f19c444a0812270942m39d35ba8teb54943a7f76e@mail.gmail.com>
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r186252 - head/sys/kern
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 27 Dec 2008 21:20:02 -0000

On 27/12/2008, Antoine Brodin <antoine@freebsd.org> wrote:
> On Wed, Dec 17, 2008 at 8:57 PM, Ivan Voras <ivoras@freebsd.org> wrote:

> Modified: head/sys/kern/subr_param.c
> [snip]
>> +enum VM_GUEST { VM_GUEST_NO, VM_GUEST_VM, VM_GUEST_XEN };
>> +
> [snip]
>> -               hz = detect_virtual() ? HZ_VM : HZ;
>> +               hz = vm_guest > VM_GUEST_NO ? HZ_VM : HZ;
> [snip]
>
> Hi Ivan,
>
> Could you change VM_GUEST_NO / VM_GUEST_VM / VM_GUEST_XEN to a #define
> or explicitly initialize them?
> The magnitude comparison between vm_guest and VM_GUEST_NO looks like
> gratuitous obfuscation.

I think that the "enum" type is very well defined and its behaviour
widely known so it is not necessary to break it into #defines. Would
you be happy if I explicitly initalized the first member of the enum
to signify its values are important?

enum VM_GUEST { VM_GUEST_NO = 0, VM_GUEST_VM, VM_GUEST_XEN };