From owner-freebsd-bugs@FreeBSD.ORG Mon Aug 31 10:00:17 2009 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A056110656B5 for ; Mon, 31 Aug 2009 10:00:17 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 9641B8FC1E for ; Mon, 31 Aug 2009 10:00:15 +0000 (UTC) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n7VA0FkS098444 for ; Mon, 31 Aug 2009 10:00:15 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n7VA0FGb098443; Mon, 31 Aug 2009 10:00:15 GMT (envelope-from gnats) Resent-Date: Mon, 31 Aug 2009 10:00:15 GMT Resent-Message-Id: <200908311000.n7VA0FGb098443@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Patroklos Argyroudis Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id B2213106566B for ; Mon, 31 Aug 2009 09:50:08 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id A11678FC0C for ; Mon, 31 Aug 2009 09:50:08 +0000 (UTC) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n7V9o88C040165 for ; Mon, 31 Aug 2009 09:50:08 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id n7V9o8RO040164; Mon, 31 Aug 2009 09:50:08 GMT (envelope-from nobody) Message-Id: <200908310950.n7V9o8RO040164@www.freebsd.org> Date: Mon, 31 Aug 2009 09:50:08 GMT From: Patroklos Argyroudis To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/138376: Memory leak in scsi_low_attach_xs() in file sys/cam/scsi/scsi_low.c X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Aug 2009 10:00:17 -0000 >Number: 138376 >Category: kern >Synopsis: Memory leak in scsi_low_attach_xs() in file sys/cam/scsi/scsi_low.c >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Mon Aug 31 10:00:15 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Patroklos Argyroudis >Release: 8.0-CURRENT >Organization: census, inc >Environment: N/A >Description: Memory leak of pointer sap if the allocation in line 639 fails. >How-To-Repeat: N/A >Fix: Patch attached. Patch attached with submission follows: --- ./sys/cam/scsi/scsi_low.c.orig 2009-08-27 16:57:59.000000000 +0300 +++ ./sys/cam/scsi/scsi_low.c 2009-08-27 17:02:12.000000000 +0300 @@ -638,7 +638,10 @@ return ENOMEM; splp = SCSI_LOW_MALLOC(sizeof(*splp)); if (splp == NULL) + { + SCSI_LOW_FREE(sap); return ENOMEM; + } SCSI_LOW_BZERO(sap, sizeof(*sap)); SCSI_LOW_BZERO(splp, sizeof(*splp)); >Release-Note: >Audit-Trail: >Unformatted: