From nobody Tue Jul 8 10:05:08 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bbxYd2Xc3z60hVx; Tue, 08 Jul 2025 10:05:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bbxYd12lTz3Fc8; Tue, 08 Jul 2025 10:05:09 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751969109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=tv4qI7+AfhceMwd+Tr2htA3NC09ddvPDKfeWgIHXtDI=; b=J/IYhDJDKcl+7lukFACZnFBjzuowpNWM9VSKLVQk/rAXjKnbWUgAY55rvLjrsuBcRCPpvX C37ctcH/yATZkoccvhtaW4pqIvkLd0w/BrFJGhY8opFlIwrna7FFaDWlP4M7SqpJRehlXx pB1e0JCKBb/julHd/ZCfk0kDdu5soZxub1N0kTwaLWsbzUUjVr3JJfDNyRI8tWJL6nIqJm hImSi06ISOFksNOkhgTDHWVV0Fs8qtlYqre965zfmq5qr/Bc6HsSP/b8AfCIGhuGeUKT9T oKZfskRcVXDeRTlD0uturK9paFWYwkRMV7JNH3hQu0aupyPkD8W/G+5e77/ksg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1751969109; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=tv4qI7+AfhceMwd+Tr2htA3NC09ddvPDKfeWgIHXtDI=; b=yj7Qx9hFjQmJx+7hUHSsD+/y6PcHE1M8vuJDr1LkqmDd7uNd/xUJUBYBHvpZg+wr9XB8ov z4WYe5/qBGRADOnM0aomNDm7PSp91GENtl7CSdzekMOeLLZClR9KeBuO5jhbXoIlEInApw 3TDwzIbocf6QLTXjVTFs+GwJ94YnZVw3TVJYC3u/IZ/ISd4dvAN9bgm3iSM5pphNu4t7Nz CMCkNnZLI+blPkoEZkJ95xCwkkiOyBNH+QU+WMRf0W7xuIsmkG7TvKvZuyvUahXeX+/yTR V1TEjnO+1xq+Pe2J3HpCDUbW2fOU2z03BTjVsurnc1nLM2L94rbVpkWHoBXuzg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1751969109; a=rsa-sha256; cv=none; b=sxWXiXF+1li6QhIz8QMkvqGrQc4+UPbKMMvmD5C2lDOHWGVlQbhgDRK0tvx46y+6mxbQc4 zUENyocf5jnMFzbc49iOV7BVCS2/6EI8rybgtQYOFZknM+WbQw4QLjdyQ9lyEbGUKf5dA0 C4dn6ci25xYWJeC74Ieg318tRyO95+1Cbc/Qy78a8tA8ubjbF7xqtqtrWjT68CbUKPQ7yH o8q0C3gMwza92XMeuQJNpCXAodX4NQ9CRu1le8WiIBZVN89yHOhMa+Uzy+mZgrYRUo0Iu8 Rp4ERsnffKVKOYYP2y7CnSRbJfrhOQ5LR8B3zY7u18D+M9/52vFTmV2JoCb8jg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bbxYd0Q3HzYgg; Tue, 08 Jul 2025 10:05:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 568A58VA067434; Tue, 8 Jul 2025 10:05:08 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 568A58lE067431; Tue, 8 Jul 2025 10:05:08 GMT (envelope-from git) Date: Tue, 8 Jul 2025 10:05:08 GMT Message-Id: <202507081005.568A58lE067431@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Zhenlei Huang Subject: git: 9d53e7eaab9e - stable/13 - pfsync: Destroy buckets mutexes on clone destroying interface List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: zlei X-Git-Repository: src X-Git-Refname: refs/heads/stable/13 X-Git-Reftype: branch X-Git-Commit: 9d53e7eaab9e2e75491941dc035a345bc0f39c99 Auto-Submitted: auto-generated The branch stable/13 has been updated by zlei: URL: https://cgit.FreeBSD.org/src/commit/?id=9d53e7eaab9e2e75491941dc035a345bc0f39c99 commit 9d53e7eaab9e2e75491941dc035a345bc0f39c99 Author: Zhenlei Huang AuthorDate: 2025-06-28 15:46:51 +0000 Commit: Zhenlei Huang CommitDate: 2025-07-08 10:03:29 +0000 pfsync: Destroy buckets mutexes on clone destroying interface So that the associated data with them will be freed. Reviewed by: kp Fixes: 4fc65bcbe3fb pfsync: Performance improvement MFC after: 1 week Differential Revision: https://reviews.freebsd.org/D51063 (cherry picked from commit 8213c07c20586a67bc7f7152bd7ff76c02cbc007) (cherry picked from commit efbaf14c5b681c8f1a04a47c7bf8740134fff098) --- sys/netpfil/pf/if_pfsync.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/sys/netpfil/pf/if_pfsync.c b/sys/netpfil/pf/if_pfsync.c index 412739513472..9eef37ff9005 100644 --- a/sys/netpfil/pf/if_pfsync.c +++ b/sys/netpfil/pf/if_pfsync.c @@ -437,6 +437,10 @@ pfsync_clone_destroy(struct ifnet *ifp) mtx_destroy(&sc->sc_mtx); mtx_destroy(&sc->sc_bulk_mtx); + for (c = 0; c < pfsync_buckets; c++) { + b = &sc->sc_buckets[c]; + mtx_destroy(&b->b_mtx); + } free(sc->sc_buckets, M_PFSYNC); free(sc, M_PFSYNC);