From owner-svn-src-all@FreeBSD.ORG Mon Jun 15 14:38:49 2015 Return-Path: Delivered-To: svn-src-all@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 5BDB93C0; Mon, 15 Jun 2015 14:38:49 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebius.int.ru (glebius.int.ru [81.19.69.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "cell.glebius.int.ru", Issuer "cell.glebius.int.ru" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id DA12F84E; Mon, 15 Jun 2015 14:38:48 +0000 (UTC) (envelope-from glebius@FreeBSD.org) Received: from cell.glebius.int.ru (localhost [127.0.0.1]) by cell.glebius.int.ru (8.14.9/8.14.9) with ESMTP id t5FEck4C015505 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 15 Jun 2015 17:38:46 +0300 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.glebius.int.ru (8.14.9/8.14.9/Submit) id t5FEckmE015504; Mon, 15 Jun 2015 17:38:46 +0300 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.glebius.int.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Mon, 15 Jun 2015 17:38:46 +0300 From: Gleb Smirnoff To: Andriy Gapon Cc: Ed Maste , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , svn-src-vendor@FreeBSD.org Subject: Re: svn commit: r284412 - in vendor-sys/illumos/dist/uts/common/fs/zfs: . sys Message-ID: <20150615143846.GZ73119@FreeBSD.org> References: <201506151250.t5FCoifP019075@svn.freebsd.org> <557ECD22.8090402@FreeBSD.org> <557ED7CC.7030002@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <557ED7CC.7030002@FreeBSD.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jun 2015 14:38:49 -0000 On Mon, Jun 15, 2015 at 04:49:00PM +0300, Andriy Gapon wrote: A> On 15/06/2015 16:42, Ed Maste wrote: A> > On 15 June 2015 at 09:03, Andriy Gapon wrote: A> >> A> >> I guess I could extend my script to expand 5911 to A> >> https://www.illumos.org/issues/5911 A> > A> > Yeah, I think that would be useful -- although it's probably too long A> > to go in the first line, then. A> > A> > I guess the problem is that the upstream Illumos commits follow a A> > certain convention, and that meaning/context is lost when they come A> > into FreeBSD. Linking to the original issue should take care of that. A> > A> A> Yes, indeed. Regular ZFS/FreeBSD hackers are aware of the conventions and A> places to look, but most of committers do not necessarily know of them. A> A> So, this is the format that I will try use (using this commit as an example): A> ======================================== A> 5911 ZFS "hangs" while deleting file A> A> Reviewed by: Bayard Bell A> Reviewed by: Alek Pinchuk A> Reviewed by: Simon Klinkert A> Reviewed by: Dan McDonald A> Approved by: Richard Lowe A> Author: Matthew Ahrens A> A> illumos/illumos-gate@46e1baa6cf6d5432f5fd231bb588df8f9570c858 A> https://www.illumos.org/issues/5911 A> ======================================== Is it possible to expand your script to fetch https://www.illumos.org/issues/$issue into your text editor, so that you can quickly cut the issue text and produce a paragraph describing the change? -- Totus tuus, Glebius.