From owner-dev-commits-src-all@freebsd.org Tue Apr 20 16:58:44 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id A15965DFBAB; Tue, 20 Apr 2021 16:58:44 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4FPqdc0dx3z3FFB; Tue, 20 Apr 2021 16:58:43 +0000 (UTC) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: from gndrsh.dnsmgr.net (localhost [127.0.0.1]) by gndrsh.dnsmgr.net (8.13.3/8.13.3) with ESMTP id 13KGwgkm071813; Tue, 20 Apr 2021 09:58:42 -0700 (PDT) (envelope-from freebsd@gndrsh.dnsmgr.net) Received: (from freebsd@localhost) by gndrsh.dnsmgr.net (8.13.3/8.13.3/Submit) id 13KGwgnh071812; Tue, 20 Apr 2021 09:58:42 -0700 (PDT) (envelope-from freebsd) From: "Rodney W. Grimes" Message-Id: <202104201658.13KGwgnh071812@gndrsh.dnsmgr.net> Subject: Re: git: 686cf5468c4a - main - flex: Regen bootstrap files In-Reply-To: <782d3c7b-fb30-d013-0426-692cc1ead645@FreeBSD.org> To: Jung-uk Kim Date: Tue, 20 Apr 2021 09:58:42 -0700 (PDT) CC: rgrimes@FreeBSD.org, src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Reply-To: rgrimes@FreeBSD.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 4FPqdc0dx3z3FFB X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Apr 2021 16:58:44 -0000 > On 21. 4. 20., Rodney W. Grimes wrote: > >> On 21. 4. 20., Rodney W. Grimes wrote: > >>>> The branch main has been updated by jkim: > >>>> > >>>> URL: https://cgit.FreeBSD.org/src/commit/?id=686cf5468c4a85c2a6385cdbab2383900876a41d > >>>> > >>>> commit 686cf5468c4a85c2a6385cdbab2383900876a41d > >>>> Author: Jung-uk Kim > >>>> AuthorDate: 2021-04-19 18:20:51 +0000 > >>>> Commit: Jung-uk Kim > >>>> CommitDate: 2021-04-19 18:20:51 +0000 > >>>> > >>>> flex: Regen bootstrap files > >>>> > >>>> This also partially reverts r326025 (8a16b7a18f5d). I do not see any > >>>> point of adding SPDX tag in generated file. > >>> > >>> The SPDX identifies the copyright that follows it, so please put this back. > >> > >> It is a generated file. If you really think it is necessary, you need > >> to patch its source, i.e., contrib/flex/src/parse.y, and regen the file. > > > > Just because it is a generated file does not change the fact that > > its contents are copyrighted. Leaving the copyright out at best > > defaults to Bern convention, so the fact of the mater is the contents > > is copyrighted, and it is best to explicitly state that it is. > > Of course, it is copyrighted. My point was parse.y should have been > patched, not the generated file, if necessary. My complaint was ABOUT the change to parse.y that REMOVED the SPDX tag. This is NOT a generated file, it IS the right place to put the SPDX, immediatly before the copyright it refers to. > >> However, I don't see much sense in automatically adding BSD license in > >> every generated file in the first place. In fact, I think it should not > >> appear on generated file at all. It may say something along the line of > >> "generated by flex" instead but IANAL. > > > > Well, someone before you did see since in it, and hence put that SPDX in it. > > Let me put it in another way. Do we really want to tag contrib code? Now that is a seperate discussion, but again, someone did infact decide to do this in the past. I am simply asking that the tag be put back. > Jung-uk Kim -- Rod Grimes rgrimes@freebsd.org