From owner-cvs-all Wed Dec 6 23:50:12 2000 From owner-cvs-all@FreeBSD.ORG Wed Dec 6 23:50:08 2000 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from fw.wintelcom.net (ns1.wintelcom.net [209.1.153.20]) by hub.freebsd.org (Postfix) with ESMTP id E711D37B400; Wed, 6 Dec 2000 23:50:07 -0800 (PST) Received: (from bright@localhost) by fw.wintelcom.net (8.10.0/8.10.0) id eB77o4B25940; Wed, 6 Dec 2000 23:50:04 -0800 (PST) Date: Wed, 6 Dec 2000 23:50:04 -0800 From: Alfred Perlstein To: "Daniel C. Sobral" Cc: Daniel Eischen , "David O'Brien" , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/vm phys_pager.c Message-ID: <20001206235004.E16205@fw.wintelcom.net> References: <20001205145908.K8051@fw.wintelcom.net> <20001205152054.M8051@fw.wintelcom.net> <3A2EFBC4.EE8D90B1@newsguy.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <3A2EFBC4.EE8D90B1@newsguy.com>; from dcs@newsguy.com on Thu, Dec 07, 2000 at 11:53:56AM +0900 Sender: bright@fw.wintelcom.net Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG * Daniel C. Sobral [001206 19:08] wrote: > Alfred Perlstein wrote: > > > > And who exactly would bump into this problem except me? > > God, how many times was the world broken because of a mistake during > commit, a missing file, a different version being committed than the one > intended, a last minute addition that couldn't possibly go wrong (and > was anyway), etc? > > I'm about to violate mailing lists charter, but I think it is > appropriate here. > > Alfred, *shit happens*. *sigh* Yes it does, like for instance turning a what should have been a 10 second downtime in order to turn on a sysctl to tune my box into a 15-20 minute downtime because the database got confused as hell when its shared segments became corrupted and I had to deduce what the heck just happened. > And it should never, ever, not by accident, not in any case, happen on > -stable. That's why there is -current, and that's why one should wait > between -current and -stable commits. > > Given all the facts, a wait of one or two weeks would certainly not be > called for, but give it a day, for Christ sake. You said yourself that > this has been broken for months. The value of fixing it one day earlier, > especially since it seems, from what you said yourself, only you have > stumbled upon it, is far less than the risk of accidentally breaking > world. > > And, far greater than both, is the value of _discipline_. As a > committer, you have a lot of power over our source tree, and, with that, > comes responsibility and the necessity of working well with the other > committers. Breaking the few established rules we have because _you_ > think they don't apply in a particular case goes against both. I am working within the rules of the committers' guide and I will not apologize for trying to fix this broken code, especially when the fix was already reviewed. > > I think a bit more faith in my work would be nice. > > If we didn't have faith in your work, you wouldn't be a committer. A bit > more faith in the few rules we have, for a good reason, would go a long > way. They are not just your rules, they are also my rules, I have some signifigant patches (loadable sysvipc) sitting here that are _not_ going into -stable right now because they just aren't -stable items and have no immediate need. I'm using my judgement and staying within the guidlines while trying to address a serious problem, you however are jumping to conclusions and wasting my time. -- -Alfred Perlstein - [bright@wintelcom.net|alfred@freebsd.org] "I have the heart of a child; I keep it in a jar on my desk." To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message