Date: Tue, 18 Feb 2014 15:13:03 +0000 From: Alan Hicks <ahicks@p-o.co.uk> To: FreeBSD-gnats-submit@freebsd.org Subject: ports/186869: [Maintainer update] Fix crashes in dbmail-imapd mail/dbmail Message-ID: <E1WFmM3-000Oeg-4J@p-o.co.uk> Resent-Message-ID: <201402181530.s1IFU1lQ088872@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 186869 >Category: ports >Synopsis: [Maintainer update] Fix crashes in dbmail-imapd mail/dbmail >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: maintainer-update >Submitter-Id: current-users >Arrival-Date: Tue Feb 18 15:30:00 UTC 2014 >Closed-Date: >Last-Modified: >Originator: Alan Hicks >Release: FreeBSD 9.2-RELEASE-p3 i386 >Organization: >Environment: System: FreeBSD schnittke.p-o.co.uk 9.2-RELEASE-p3 FreeBSD 9.2-RELEASE-p3 #0: Sat Jan 11 02:38:15 UTC 2014 root@amd64-builder.daemonology.net:/usr/obj/usr/src/sys/GENERIC i386 >Description: Fix crashes in dbmail-pop3d as per http://www.dbmail.org/mantis/view.php?id=1043 >How-To-Repeat: Random crashes as reported and confirmed upstream. >Fix: Apply attached patch. --- dbmail-3.1.10-20140217.diff begins here --- diff -urN dbmail/Makefile dbmail/Makefile --- dbmail/Makefile 2014-01-23 22:52:32.000000000 +0000 +++ dbmail/Makefile 2014-02-17 17:09:14.000000000 +0000 @@ -3,6 +3,7 @@ PORTNAME= dbmail PORTVERSION= 3.1.10 +PORTREVISION= 1 CATEGORIES= mail MASTER_SITES= http://www.dbmail.org/download/3.1/ \ http://git.dbmail.eu/paul/dbmail/snapshot/ diff -urN dbmail/files/patch-src_db__dm.c dbmail/files/patch-src_db__dm.c --- dbmail/files/patch-src_db__dm.c 1970-01-01 01:00:00.000000000 +0100 +++ dbmail/files/patch-src_db__dm.c 2014-02-17 16:40:23.000000000 +0000 @@ -0,0 +1,15 @@ +diff --git src/dm_db.c b/src/dm_db.c +index 559d83c..529a48e 100644 +--- src/dm_db.c ++++ src/dm_db.c +@@ -1832,7 +1832,9 @@ char * db_get_message_lines(uint64_t message_idnr, long lines) + return NULL; + + msg = dbmail_message_new(NULL); +- msg = dbmail_message_retrieve(msg, physmessage_id); ++ if (! (msg = dbmail_message_retrieve(msg, physmessage_id))) ++ return NULL; ++ + stream = msg->crlf; + + if (lines >=0) { diff -urN dbmail/files/patch-src_pop3.c dbmail/files/patch-src_pop3.c --- dbmail/files/patch-src_pop3.c 1970-01-01 01:00:00.000000000 +0100 +++ dbmail/files/patch-src_pop3.c 2014-02-17 16:41:17.000000000 +0000 @@ -0,0 +1,20 @@ +diff --git src/pop3.c src/pop3.c +index 2b8792e..a09524e 100644 +--- src/pop3.c ++++ src/pop3.c +@@ -302,7 +302,6 @@ int pop3_error(ClientSession_T * session, const char *formatstring, ...) + + if (session->error_count >= MAX_ERRORS) { + ci_write(ci, "-ERR too many errors\r\n"); +- client_session_bailout(&session); + return -3; + } + va_start(ap, formatstring); +@@ -314,7 +313,6 @@ int pop3_error(ClientSession_T * session, const char *formatstring, ...) + g_free(s); + + if (ci->client_state & CLIENT_ERR) { +- client_session_bailout(&session); + return -3; + } + --- dbmail-3.1.10-20140217.diff ends here --- >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E1WFmM3-000Oeg-4J>