Date: Thu, 19 Sep 2024 12:49:24 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 279816] Avoid defaulting to GH when USE_GITLAB and USE_GITHUB=nodefault is set Message-ID: <bug-279816-7788-32Mag8k1Lj@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-279816-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-279816-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D279816 --- Comment #1 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/ports/commit/?id=3D067905614d641e8a3fa3af3aa2d02b0= 4a28b7185 commit 067905614d641e8a3fa3af3aa2d02b04a28b7185 Author: Brad Davis <brd@FreeBSD.org> AuthorDate: 2024-09-19 12:26:24 +0000 Commit: Mathieu Arnold <mat@FreeBSD.org> CommitDate: 2024-09-19 12:48:25 +0000 Mk/bsd.sites.mk: don't add GH to MASTER_SITES when USE_GITHUB=3Dnodefau= lt When using USE_GITHUB=3Dnodefault, we don't need to add GH to MASTER_SITES, as the github urls that are needed will be added later. Adding GH here means we'll add a generic GitHub URL to the fetch list, in the form of github.com/<portname>/<portname>/.../<dist> which will not work. When used with USE_GITLAB the framework will add this bogus URL before the correct gitlab url. It does not prevent the distfile to be fetched from gitlab, but it makes everyone try and fetch from a bogus url before trying the correct url. PR: 279816 Mk/bsd.sites.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --=20 You are receiving this mail because: You are on the CC list for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-279816-7788-32Mag8k1Lj>