From owner-svn-ports-all@FreeBSD.ORG Mon Dec 31 17:49:15 2012 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F115338F for ; Mon, 31 Dec 2012 17:49:14 +0000 (UTC) (envelope-from bsd-src@helfman.org) Received: from mail-vc0-f182.google.com (mail-vc0-f182.google.com [209.85.220.182]) by mx1.freebsd.org (Postfix) with ESMTP id 92DFE8FC15 for ; Mon, 31 Dec 2012 17:49:14 +0000 (UTC) Received: by mail-vc0-f182.google.com with SMTP id fy27so13086734vcb.13 for ; Mon, 31 Dec 2012 09:49:13 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :x-gm-message-state; bh=jKu85nsnjLndUE93TV/uimHZcTL8X1vYKcKO+b8VTQQ=; b=A/XUofo3y4ZsEJRbaOThQSnOLaCQSUEeJCTFINoeOaVLZTRDSImyAfK7iSR48g5t+K 0nShvONxjx8g8BKdAF9GpZGmETniUgqD40K4/ls3bMWjx7D1v6YRW1iPtr+2LAkRWoOD igC47B8jfciQlChdqTGUG9qk+gysXfOp631wXq+fsQS0xFdHdaD+ZPb+e/1tguLm+V7p Noi287qHwO5+15k496b6SUPhnBagzmJ2att9XBIv3hv1wSHnV+VCFHxNE469SgIoXj1H zK8QLpbXgW2aWNl81A/L6FwteSKyJKgBWaTNbZTvIbKY//QDw4SkluovFnN79dgl2lUF 3B7Q== MIME-Version: 1.0 Received: by 10.52.22.240 with SMTP id h16mr57174791vdf.82.1356976153738; Mon, 31 Dec 2012 09:49:13 -0800 (PST) Sender: bsd-src@helfman.org Received: by 10.58.161.165 with HTTP; Mon, 31 Dec 2012 09:49:13 -0800 (PST) In-Reply-To: <8701822.2t1vcGT59x@mocha.verizon.net> References: <201212310346.qBV3kR0W049479@svn.freebsd.org> <8701822.2t1vcGT59x@mocha.verizon.net> Date: Mon, 31 Dec 2012 09:49:13 -0800 X-Google-Sender-Auth: B9S-s4wsCSC7z6mceXmVws01MoA Message-ID: Subject: Re: svn commit: r309705 - in head/irc: . dxirc From: Jason Helfman To: "Jason E. Hale" X-Gm-Message-State: ALoCoQmi9/b3NPOfyjj7m6L+u9GqfjkEkE+07NwJ32k2fLNZtz8yejdgz2Ykxbmu/PyZg440oGh2 Content-Type: text/plain; charset=ISO-8859-1 X-Content-Filtered-By: Mailman/MimeDel 2.1.14 Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Baptiste Daroussin , ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Dec 2012 17:49:15 -0000 On Mon, Dec 31, 2012 at 6:06 AM, Jason E. Hale wrote: > On Monday, December 31, 2012 03:46:27 Jason Helfman wrote: > > Added: head/irc/dxirc/Makefile > > > ============================================================================ > > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > > +++ head/irc/dxirc/Makefile Mon Dec 31 03:46:26 2012 (r309705) > > @@ -0,0 +1,80 @@ > > > > +LICENSE= GPLv3 > > +LICENSE_FILE= ${WRKSRC}/COPYING > > LICENSE_FILE should be dropped for standard license > > Did you compare the license files before making this comment? > +LIB_DEPENDS= FOX-1:${PORTSDIR}/x11-toolkits/fox16 > > The library name is FOX-1.6 despite portlint warnings ".6" is not an ABI > version number. > > Another reason to drop the ABI warning from portlint. Builds still passed with, and without it. I will restore it. IMHO I am not in favor of portlint warnings for this. > > +OPTIONS_DEFINE= NLS TRAY IPV6 SSL LUA ENCHANT NOTIFY > > +OPTIONS_DEFAULT= NLS TRAY IPV6 SSL LUA > > NLS doesn't need to be in OPTIONS_DEFAULT...it is already default. Might > as > well add DOCS to OPTIONS_DEFINE too. > > I wanted to honor what the contributor wanted for defaults in the future if the defaults ever are to change. I don't see how naming them explicitly is a problem. > > Added: head/irc/dxirc/pkg-plist > > > ============================================================================ > > == --- /dev/null 00:00:00 1970 (empty, because file is newly > added) > > +++ head/irc/dxirc/pkg-plist Mon Dec 31 03:46:26 2012 (r309705) > > @@ -0,0 +1,297 @@ > > +%%DATADIR%%/COPYING > > Since LICENSE is already defined, the installation of an additional license > file should be squashed. > Good catch. Thanks! > > > +@dirrm share/applications > > This should be a @dirrmtry since it is a shared directory. > > Good catch. Thanks! -jgh