From owner-p4-projects@FreeBSD.ORG  Fri Dec  4 17:27:30 2009
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 10DA61065672; Fri,  4 Dec 2009 17:27:30 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C9542106566B
	for <perforce@FreeBSD.org>; Fri,  4 Dec 2009 17:27:29 +0000 (UTC)
	(envelope-from truncs@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id B70048FC15
	for <perforce@FreeBSD.org>; Fri,  4 Dec 2009 17:27:29 +0000 (UTC)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id nB4HRTgN061993
	for <perforce@FreeBSD.org>; Fri, 4 Dec 2009 17:27:29 GMT
	(envelope-from truncs@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.3/8.14.3/Submit) id nB4HRTZG061990
	for perforce@freebsd.org; Fri, 4 Dec 2009 17:27:29 GMT
	(envelope-from truncs@FreeBSD.org)
Date: Fri, 4 Dec 2009 17:27:29 GMT
Message-Id: <200912041727.nB4HRTZG061990@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	truncs@FreeBSD.org using -f
From: Aditya Sarawgi <truncs@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Precedence: bulk
Cc: 
Subject: PERFORCE change 171385 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 04 Dec 2009 17:27:30 -0000

http://p4web.freebsd.org/chv.cgi?CH=171385

Change 171385 by truncs@aditya on 2009/12/04 17:27:18

	Use EXT2_LOCK only once instead of using it twice.

Affected files ...

.. //depot/projects/soc2009/soc_ext2fs/src/sys/fs/ext2fs/ext2_balloc.c#11 edit

Differences ...

==== //depot/projects/soc2009/soc_ext2fs/src/sys/fs/ext2fs/ext2_balloc.c#11 (text+ko) ====

@@ -207,13 +207,10 @@
 			bqrelse(bp);
 			continue;
 		}
-		if (pref == 0) {
-			EXT2_LOCK(ump);
+		EXT2_LOCK(ump);
+		if (pref == 0)
 			pref = ext2_blkpref(ip, lbn, indirs[i].in_off, bap,
 						bp->b_lblkno);
-
-		} else
-			EXT2_LOCK(ump);
 		error =  ext2_alloc(ip, lbn, pref, (int)fs->e2fs_bsize, cred, &newb);
 		if(error) {
 			brelse(bp);
@@ -291,3 +288,4 @@
 	*bpp = nbp;
 	return (0);
 }
+