From owner-svn-src-head@freebsd.org Tue Feb 4 19:32:49 2020 Return-Path: Delivered-To: svn-src-head@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 771BC2316E7; Tue, 4 Feb 2020 19:32:49 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "cell.glebi.us", Issuer "cell.glebi.us" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 48Bvwx0LRmz4QlS; Tue, 4 Feb 2020 19:32:48 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from cell.glebi.us (localhost [127.0.0.1]) by cell.glebi.us (8.15.2/8.15.2) with ESMTPS id 014JWdnn002705 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Tue, 4 Feb 2020 11:32:40 -0800 (PST) (envelope-from glebius@freebsd.org) Received: (from glebius@localhost) by cell.glebi.us (8.15.2/8.15.2/Submit) id 014JWdhx002704; Tue, 4 Feb 2020 11:32:39 -0800 (PST) (envelope-from glebius@freebsd.org) X-Authentication-Warning: cell.glebi.us: glebius set sender to glebius@freebsd.org using -f Date: Tue, 4 Feb 2020 11:32:39 -0800 From: Gleb Smirnoff To: Kristof Provost Cc: Ilja Van Sprundel , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r357233 - head/sys/net Message-ID: <20200204193239.GR1268@FreeBSD.org> References: <202001282244.00SMiPrb077446@repo.freebsd.org> <20200130163455.GH1268@FreeBSD.org> <3F7A5204-4437-4845-8E40-0BC5D1CD0A5B@FreeBSD.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <3F7A5204-4437-4845-8E40-0BC5D1CD0A5B@FreeBSD.org> User-Agent: Mutt/1.12.2 (2019-09-21) X-Rspamd-Queue-Id: 48Bvwx0LRmz4QlS X-Spamd-Bar: - Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-1.52 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_HAM_MEDIUM(-0.64)[-0.637,0]; ASN(0.00)[asn:27348, ipnet:162.251.186.0/24, country:US]; NEURAL_HAM_LONG(-0.89)[-0.888,0] X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Feb 2020 19:32:49 -0000 Kristof, On Sat, Feb 01, 2020 at 07:26:48PM +0000, Kristof Provost wrote: K> > K> -/* The below interface used only by epair(4). */ K> > K> +/* The below interfaces are used only by epair(4). */ K> > K> +void if_clone_addif(struct if_clone *, struct ifnet *); K> > K> int if_clone_destroyif(struct if_clone *, struct ifnet *); K> > K> > IMHO, makes sense to move all these declaration into if_epair.c K> > itself. K> > K> Yeah, that does make sense. K> K> One minor issue is that it turns out that if_clone_destroyif() isn’t K> just used by if_epair, but also by the wifi code. K> K> How does this look? Yes, that's what I suggested. However, now given that net80211 also uses one of these methods, I'm not sure if isolating is a right move. In general, we consider if_clone KPI an internal one, don't we? I mean we don't expect 3rd party device drivers to use it. So may be it is fine that if_clone.h exposes those functions? If no, then we probably should hide both if_clone_addif and if_clone_destroyif away from if_clone.h and declare them as extern in epair and net80211. -- Gleb Smirnoff