From owner-svn-src-head@FreeBSD.ORG  Tue Oct 28 18:26:44 2014
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 0C334197;
 Tue, 28 Oct 2014 18:26:44 +0000 (UTC)
Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id D504E233;
 Tue, 28 Oct 2014 18:26:43 +0000 (UTC)
Received: from jhbbsd.localnet (unknown [209.249.190.124])
 by bigwig.baldwin.cx (Postfix) with ESMTPSA id B311EB984;
 Tue, 28 Oct 2014 14:26:42 -0400 (EDT)
From: John Baldwin <jhb@freebsd.org>
To: Konstantin Belousov <kostikbel@gmail.com>
Subject: Re: svn commit: r273785 - head/sys/kern
Date: Tue, 28 Oct 2014 13:38:23 -0400
User-Agent: KMail/1.13.5 (FreeBSD/8.4-CBSD-20140415; KDE/4.5.5; amd64; ; )
References: <201410281530.s9SFUYBd015691@svn.freebsd.org>
 <20141028154006.GG1877@kib.kiev.ua>
In-Reply-To: <20141028154006.GG1877@kib.kiev.ua>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Message-Id: <201410281338.23538.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7
 (bigwig.baldwin.cx); Tue, 28 Oct 2014 14:26:42 -0400 (EDT)
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
 src-committers@freebsd.org, Konstantin Belousov <kib@freebsd.org>
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 28 Oct 2014 18:26:44 -0000

On Tuesday, October 28, 2014 11:40:06 am Konstantin Belousov wrote:
> On Tue, Oct 28, 2014 at 03:30:34PM +0000, Konstantin Belousov wrote:
> > Author: kib
> > Date: Tue Oct 28 15:30:33 2014
> > New Revision: 273785
> > URL: https://svnweb.freebsd.org/changeset/base/273785
> > 
> > Log:
> >   Convert kern_umtx.c to use fueword() and casueword().
> >   
> >   Also fix some mishandling of suword(9) errors as errno, which resulted
> >   in spurious ERESTART.
> >   
> >   Sponsored by:	The FreeBSD Foundation
> >   Tested by:	pho
> >   MFC after:	3 weeks
> > 
> > Modified:
> >   head/sys/kern/kern_umtx.c
> 
> Some explanation which I did not want to put into commit message.
> 
> The kern_umtx.c commit is split from the other conversion commit
> for ease of reversal.  The most tricky part of the work for fueword()
> was to preserve the logic of locking loops which rely on the suspension
> check functions errors preserved for next iteration.  Another cause
> of troubles if kern_umtx.c were incomplete cleanups in case of
> userspace access errors, which left umtx sleepchains locked.
> 
> The only consumers of fuword() left in tree are solaris compat layer/dtrace.
> 
> Architectures which lack proper fueword() implementations are arm,
> mips and sparc64. I already forgot enough of sparc64 assembly, and do
> not know mips and arm. These arches currently should run with compat
> shims in subr_uio.c, but hopefully maintaners will plug the missed
> implementations.

Thanks for fixing this!

-- 
John Baldwin