From owner-svn-src-head@FreeBSD.ORG Wed Nov 10 01:26:16 2010 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0EF2B1065670; Wed, 10 Nov 2010 01:26:16 +0000 (UTC) (envelope-from yanegomi@gmail.com) Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id 6EF668FC15; Wed, 10 Nov 2010 01:26:14 +0000 (UTC) Received: by wwb22 with SMTP id 22so124370wwb.31 for ; Tue, 09 Nov 2010 17:26:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:sender:received :in-reply-to:references:date:x-google-sender-auth:message-id:subject :from:to:cc:content-type:content-transfer-encoding; bh=jSJcRVQNEV/xrsTpP3B47NUMB4W6SKN8oW9z0olafzc=; b=AjqMk+xc95lfrzD7by4Or4yuc8rOG52FeJJ5avUnh03bIl/9SOncUjWa+iQy/QwprK UndazXDc+UZSEYIS/oCC2mV9U6A/I6NlagCutdkJO+z5m09JTxytk+OcotldZzh3Gc0r VqGBexkb0gisdkMcVCt4pFxYJQyaEdgQHPtUQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; b=xRcabBimux4SN3z8DB+Q3sZ4GilDoFCsUMdPgQ3Yv6Ai4iORnpmf/oiYijiIjN/BYW GUJUXCfdlWPbfL2jHedqyCNi+Sr9s2aVYxYt4uG1NZ/kk8l7OwETj/EnBNs7MAHHYcd1 PUtgtNmJyzAmZ64CYdpHEJM9a3o8rZXrWFqOc= MIME-Version: 1.0 Received: by 10.216.175.18 with SMTP id y18mr7733345wel.30.1289352374166; Tue, 09 Nov 2010 17:26:14 -0800 (PST) Sender: yanegomi@gmail.com Received: by 10.216.198.27 with HTTP; Tue, 9 Nov 2010 17:26:14 -0800 (PST) In-Reply-To: References: <201011100056.oAA0uimN067694@svn.freebsd.org> Date: Tue, 9 Nov 2010 17:26:14 -0800 X-Google-Sender-Auth: ne58u1FlJVGAYdIayEgr8oifTjA Message-ID: From: Garrett Cooper To: Warner Losh Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r215070 - head/tools/tools/nanobsd X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Nov 2010 01:26:16 -0000 On Tue, Nov 9, 2010 at 5:25 PM, Garrett Cooper wrote: > On Tue, Nov 9, 2010 at 4:56 PM, Warner Losh wrote: >> Author: imp >> Date: Wed Nov 10 00:56:44 2010 >> New Revision: 215070 >> URL: http://svn.freebsd.org/changeset/base/215070 >> >> Log: >> =A0Build make.conf when the world is not selected to build, but the >> =A0kernel is. >> >> =A0PR: =A0 =A0 =A0 =A0 =A0 151696 >> =A0Submitted by: lev@ >> >> Modified: >> =A0head/tools/tools/nanobsd/nanobsd.sh >> >> Modified: head/tools/tools/nanobsd/nanobsd.sh >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- head/tools/tools/nanobsd/nanobsd.sh Wed Nov 10 00:39:42 2010 =A0 =A0= =A0 =A0(r215069) >> +++ head/tools/tools/nanobsd/nanobsd.sh Wed Nov 10 00:56:44 2010 =A0 =A0= =A0 =A0(r215070) >> @@ -917,6 +917,9 @@ else >> =A0fi >> >> =A0if $do_kernel ; then >> + =A0 =A0 =A0 if ! $do_world ; then >> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 make_conf_build >> + =A0 =A0 =A0 fi >> =A0 =A0 =A0 =A0build_kernel >> =A0else >> =A0 =A0 =A0 =A0pprint 2 "Skipping buildkernel (as instructed)" > > =A0 =A0Funny that it overwrites __MAKE_CONF, but not SRCCONF (seems like > the latter would infect a system more than the former *shrugs*); I > think I understand why it's not set in this script though, because > IIRC src.conf predates nanobsd. > =A0 =A0I set my core variables and features in src.conf so I think it'd > probably be better to block that out too. > =A0 =A0Should I provide a patch for this item? Sorry for the spam. I sent the email to the wrong list. -Garrett