From owner-freebsd-arch@FreeBSD.ORG Wed Oct 24 23:26:42 2007 Return-Path: Delivered-To: arch@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C73BD16A418; Wed, 24 Oct 2007 23:26:42 +0000 (UTC) (envelope-from boris@brooknet.com.au) Received: from pecan.exetel.com.au (pecan.exetel.com.au [220.233.0.17]) by mx1.freebsd.org (Postfix) with ESMTP id 8974613C465; Wed, 24 Oct 2007 23:26:42 +0000 (UTC) (envelope-from boris@brooknet.com.au) Received: from 28.201.233.220.exetel.com.au ([220.233.201.28] helo=[192.168.100.148]) by pecan.exetel.com.au with esmtp (Exim 4.63) (envelope-from ) id 1Ikmut-0001e6-C8; Thu, 25 Oct 2007 06:33:27 +1000 In-Reply-To: <200710171245.36949.jhb@freebsd.org> References: <200710171245.36949.jhb@freebsd.org> Mime-Version: 1.0 (Apple Message framework v752.3) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: Content-Transfer-Encoding: 7bit From: Sam Lawrance Date: Thu, 25 Oct 2007 06:33:49 +1000 To: John Baldwin X-Mailer: Apple Mail (2.752.3) Cc: arch@freebsd.org Subject: Re: sensors fun.. X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 Oct 2007 23:26:42 -0000 On 18/10/2007, at 2:45 AM, John Baldwin wrote: > [Trying to redirect this off cvs-all & friends.. ] > > So as I said previously, I thought about this some more offline > last night / > this morning and looked at the code some and here are my thoughts: > > Things I like about the current sensors code: > > - I like the actual sensor object used to represent a sensor. It > has a few > basic things like a string for a name, a type (I would have just done > a "units" for the value, but the type is basically that), and a > basic alarm > state. (I might have done 4 states, think green, yellow, orange, > red mapped > to good, warning, critical, bad. However, the 3 states in the > current code > is fine. 4 states might be overkill.) Perhaps an "unknown" state would be useful for those times when things aren't going quite right.