From owner-svn-src-all@freebsd.org  Sun Jan 31 21:22:11 2016
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 9D89EA73CAA;
 Sun, 31 Jan 2016 21:22:11 +0000 (UTC)
 (envelope-from dteske@FreeBSD.org)
Received: from repo.freebsd.org (repo.freebsd.org
 [IPv6:2610:1c1:1:6068::e6a:0])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 671AFD03;
 Sun, 31 Jan 2016 21:22:11 +0000 (UTC)
 (envelope-from dteske@FreeBSD.org)
Received: from repo.freebsd.org ([127.0.1.37])
 by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id u0VLMAcU003682;
 Sun, 31 Jan 2016 21:22:10 GMT (envelope-from dteske@FreeBSD.org)
Received: (from dteske@localhost)
 by repo.freebsd.org (8.15.2/8.15.2/Submit) id u0VLMAOC003681;
 Sun, 31 Jan 2016 21:22:10 GMT (envelope-from dteske@FreeBSD.org)
Message-Id: <201601312122.u0VLMAOC003681@repo.freebsd.org>
X-Authentication-Warning: repo.freebsd.org: dteske set sender to
 dteske@FreeBSD.org using -f
From: Devin Teske <dteske@FreeBSD.org>
Date: Sun, 31 Jan 2016 21:22:10 +0000 (UTC)
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
Subject: svn commit: r295101 - head/usr.sbin/bsdconfig/share
X-SVN-Group: head
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 31 Jan 2016 21:22:11 -0000

Author: dteske
Date: Sun Jan 31 21:22:10 2016
New Revision: 295101
URL: https://svnweb.freebsd.org/changeset/base/295101

Log:
  Optimize f_sprintf() for bash
  
  bash lacks the ksh93 optimization that makes sub-shells fast if they do
  not alter io. bash 3.1-alpha1 introduced printf -v var_to_set which is not
  as fast but is still significantly faster than var_to_set=$( printf ) when
  using any version of bash. If we find our interpreter to somehow be bash
  by invocation or inclusion, use the feature that provides fastest results.

Modified:
  head/usr.sbin/bsdconfig/share/strings.subr

Modified: head/usr.sbin/bsdconfig/share/strings.subr
==============================================================================
--- head/usr.sbin/bsdconfig/share/strings.subr	Sun Jan 31 21:14:31 2016	(r295100)
+++ head/usr.sbin/bsdconfig/share/strings.subr	Sun Jan 31 21:22:10 2016	(r295101)
@@ -138,7 +138,15 @@ f_sprintf()
 {
 	local __var_to_set="$1"
 	shift 1 # var_to_set
-	eval "$__var_to_set"=\$\( printf -- \"\$@\" \)
+
+	case "$BASH_VERSION" in
+	3.1*|4.*)
+		local __tmp
+		printf -v __tmp "$@"
+		eval "$__var_to_set"=\"\${__tmp%\$NL}\"
+		;;
+	*) eval "$__var_to_set"=\$\( printf -- \"\$@\" \)
+	esac
 }
 
 # f_vsnprintf $var_to_set $size $format $format_args