Date: Sat, 20 Aug 2022 14:11:43 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 265651] [NEW PORT] archivers/zpaqfranz: versioned/snapshot archive Message-ID: <bug-265651-7788-T4ut6ysy6q@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-265651-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-265651-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D265651 --- Comment #19 from Felix Palmen <zirias@freebsd.org> --- Hi Franco, I now had another look. I let it sit for a while to give time thinking about it... First of all, about the architecture restriction again. Of course, as you're also the upstream author, you're in two different roles here. If you remove code you consider "untrusted", so it will (for now) only work on amd64, tha= t's fine. It just leaves me a bit confused why you first submitted a version without that restriction (and were fine with using said "untrusted" code on i386 in case the *build* machine would not support SSE2)? So, in a nutshell, are you really sure about that? Testing the port, i noticed two more things: * You link statically. Normally, you only do that for distributing software outside of any "package management", and FreeBSD ports would typically patch upstream Makefiles not to do that if there's no really unavoidable reason. = Now, as you are the upstream author yourself, would you mind changing your own Makefile so it *doesn't* link statically? (related question, why is C++ code compiled using ${CC}, so you have to explicitly link libstdc++?) * The 'dir' incarnation vanished completely. I'm still not sure whether it would do what I *assume* it would (behave differently depending on argv[0]), but *if* it does and this behavior is useful to the user, please just add a symlink. That's the typical practice, you can e.g. see it used by vim: $ file /usr/local/bin/gvim /usr/local/bin/gvim: symbolic link to vim --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-265651-7788-T4ut6ysy6q>