From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Mar 2 06:10:02 2008 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 09DAF1065670 for ; Sun, 2 Mar 2008 06:10:02 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id D31C18FC20 for ; Sun, 2 Mar 2008 06:10:01 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m226A1YP068875 for ; Sun, 2 Mar 2008 06:10:01 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m226A1qK068874; Sun, 2 Mar 2008 06:10:01 GMT (envelope-from gnats) Resent-Date: Sun, 2 Mar 2008 06:10:01 GMT Resent-Message-Id: <200803020610.m226A1qK068874@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Edwin Groothuis Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 57C9D1065671 for ; Sun, 2 Mar 2008 06:04:57 +0000 (UTC) (envelope-from edwin@mavetju.org) Received: from mail5out.barnet.com.au (mail5.barnet.com.au [202.83.178.78]) by mx1.freebsd.org (Postfix) with ESMTP id 19C0A8FC1D for ; Sun, 2 Mar 2008 06:04:56 +0000 (UTC) (envelope-from edwin@mavetju.org) Received: by mail5out.barnet.com.au (Postfix, from userid 1001) id 54DB522189EA; Sun, 2 Mar 2008 17:04:55 +1100 (EST) Received: from mail5auth.barnet.com.au (mail5.barnet.com.au [202.83.178.78]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "mail5auth.barnet.com.au", Issuer "*.barnet.com.au" (verified OK)) by mail5.barnet.com.au (Postfix) with ESMTP id 01A3F21B1E45 for ; Sun, 2 Mar 2008 17:04:55 +1100 (EST) Received: from k7.mavetju (k7.mavetju.org [10.251.1.18]) by mail5auth.barnet.com.au (Postfix) with ESMTP id 58B4C2218827 for ; Sun, 2 Mar 2008 17:04:54 +1100 (EST) Received: by k7.mavetju (Postfix, from userid 1001) id 1687D169; Sun, 2 Mar 2008 17:04:54 +1100 (EST) Message-Id: <20080302060454.1687D169@k7.mavetju> Date: Sun, 2 Mar 2008 17:04:54 +1100 (EST) From: Edwin Groothuis To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/121279: [patch] bsd.gnome.mk - throw warning when bsd.gnome.mk isn't included properly. X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Edwin Groothuis List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Mar 2008 06:10:02 -0000 >Number: 121279 >Category: ports >Synopsis: [patch] bsd.gnome.mk - throw warning when bsd.gnome.mk isn't included properly. >Confidential: no >Severity: serious >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Sun Mar 02 06:10:01 UTC 2008 >Closed-Date: >Last-Modified: >Originator: Edwin Groothuis >Release: FreeBSD 6.3-RELEASE i386 >Organization: - >Environment: System: FreeBSD k7.mavetju 6.3-RELEASE FreeBSD 6.3-RELEASE #0: Sun Feb 17 22:11:52 EST 2008 edwin@k7.mavetju:/usr/src/sys/i386/compile/SMP i386 >Description: When you define USE_GNOME after the bsd.port.pre.mk and haven't used WANT_GNOME, you can get a strange error like this: print/ghostscript-gpl WITH_SHLIB=yes: "/usr/ports/Mk/bsd.port.mk", line 6147: if-less endif With the patch attached it will throw a more understandable error: [~/cvs/ports/print/ghostscript-gpl] edwin@k7>make config "/usr/ports/Mk/bsd.gnome.mk", line 606: error: The Pre include part of bsd.gnome.mk part isn't included. Did you forget WANT_GNOME=yes before bsd.port.pre.mk? Yes, I know that it is the responsibility of the maintainer of the port to check this all, but this was an option which was normally not used. >How-To-Repeat: >Fix: --- bsd.gnome.mk.orig 2008-03-02 16:55:36.000000000 +1100 +++ bsd.gnome.mk 2008-03-02 16:56:52.000000000 +1100 @@ -602,6 +602,10 @@ Gnome_Post_Include= bsd.gnome.mk +.if !defined(Gnome_Pre_Include) +.error The Pre include part of bsd.gnome.mk part isn't included. Did you forget WANT_GNOME=yes before bsd.port.pre.mk? +.endif + # DO NOT USE THESE MACROS! They are obsolete, and only provided for # backward compatibility with old ports that have not converted to the new # GNOME infrastructure. >Release-Note: >Audit-Trail: >Unformatted: