From owner-freebsd-current Thu Dec 14 4:19: 4 2000 From owner-freebsd-current@FreeBSD.ORG Thu Dec 14 04:19:00 2000 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id 215E937B69D; Thu, 14 Dec 2000 04:18:52 -0800 (PST) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id XAA23984; Thu, 14 Dec 2000 23:18:42 +1100 Date: Thu, 14 Dec 2000 23:18:41 +1100 (EST) From: Bruce Evans X-Sender: bde@besplex.bde.org To: Benno Rice Cc: freebsd-current@FreeBSD.ORG Subject: Re: Patch to allow overriding of nm in lorder, genassym.sh In-Reply-To: <20001213224645.A16171@rafe.jeamland.net> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On Wed, 13 Dec 2000, Benno Rice wrote: > Does anyone object to me committing the attached patch? > > It basically allows the overriding of nm in lorder(1) and sys/kern/genassym.sh > using the environment variable NM. > > I've been using this locally as I've been building with 'powerpc-elf-nm' > rather than nm. > > Comments? Objections? Review? =) I don't like this much. I think I would prefer to use an extension of OBJFORMAT to control all binary utilites consistently. Where do you set NM and corresponding variables for other binary utilities? genassym.sh and lorder.sh are also missing support for the -aout/-elf command line option, and this breaks building of kernels in a non-native object format. I think the correct fix is is to set OBJFORMAT before running shell scripts that run binary utilities, not to clutter the shell scripts with code to select the correct binarary utility. Setting OBJFORMAT globally works in many cases, but not in kernel makefiles, because at least the aicasm needs to be built with the default object format. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message