Date: Fri, 8 Dec 2006 11:50:09 GMT From: Eygene Ryabinkin <rea-fbsd@codelabs.ru> To: freebsd-usb@FreeBSD.org Subject: Re: usb/106435: Possible buffer overflow in dev/usb/ums.c Message-ID: <200612081150.kB8Bo9d7072382@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR usb/106435; it has been noted by GNATS.
From: Eygene Ryabinkin <rea-fbsd@codelabs.ru>
To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-usb@FreeBSD.org
Cc:
Subject: Re: usb/106435: Possible buffer overflow in dev/usb/ums.c
Date: Fri, 8 Dec 2006 14:40:36 +0300
Sorry, missed the double quote in the patch. The real patch
should be:
--- ums.c.orig Tue Dec 5 13:29:34 2006
+++ ums.c Tue Dec 5 13:31:40 2006
@@ -431,9 +431,10 @@
#define UMS_BUT(i) ((i) < 3 ? (((i) + 2) % 3) : (i))
DPRINTFN(5, ("ums_intr: sc=%p status=%d\n", sc, status));
- DPRINTFN(5, ("ums_intr: data = %02x %02x %02x %02x %02x %02x\n",
- sc->sc_ibuf[0], sc->sc_ibuf[1], sc->sc_ibuf[2],
- sc->sc_ibuf[3], sc->sc_ibuf[4], sc->sc_ibuf[5]));
+ DPRINTFN(5, ("ums_intr: data ="));
+ for (i = 0; i < sc->sc_isize; i++)
+ DPRINTFN(5, (" %02x", sc->sc_ibuf[i]));
+ DPRINTFN(5, ("\n"));
if (status == USBD_CANCELLED)
return;
--
Eygene
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200612081150.kB8Bo9d7072382>