From owner-freebsd-current@FreeBSD.ORG Wed Nov 9 16:42:59 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 27C0A1065670 for ; Wed, 9 Nov 2011 16:42:59 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (lor.one-eyed-alien.net [69.66.77.232]) by mx1.freebsd.org (Postfix) with ESMTP id 3150C8FC17 for ; Wed, 9 Nov 2011 16:42:57 +0000 (UTC) Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.14.4/8.14.4) with ESMTP id pA9G1wep055767; Wed, 9 Nov 2011 10:01:58 -0600 (CST) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.14.4/8.14.4/Submit) id pA9G1wEd055766; Wed, 9 Nov 2011 10:01:58 -0600 (CST) (envelope-from brooks) Date: Wed, 9 Nov 2011 10:01:58 -0600 From: Brooks Davis To: Ryan Stone Message-ID: <20111109160158.GA55645@lor.one-eyed-alien.net> References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="sm4nu43k4a2Rpi4c" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Cc: FreeBSD Current Subject: Re: [PATCH] Allow syslogd to accept multiple configuration files X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Nov 2011 16:42:59 -0000 --sm4nu43k4a2Rpi4c Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Nov 09, 2011 at 10:27:44AM -0500, Ryan Stone wrote: > I've written the following patch to allow syslogd to accept multiple > configuration files by passing multiple -f options. One use case for > this is to specify a common configuration file that applies across > multiple machines along with a second config file specific to the > local machine. >=20 > The patch can also be found at > http://people.freebsd.org/~rstone/patches/syslogd-multiconf.diff >=20 > (Oh, and before somebody asks, the reason that I converted struct > filed to use a TAILQ was that at one point I found myself typing > struct filed ***, then hit myself and refactored the code instead). I gave it a once over and it looks good. Do you happen to know why the code calloc's the struct filed's with 1's? I didn't do any investigation but that's seems like an odd pattern. -- Brooks --sm4nu43k4a2Rpi4c Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iD8DBQFOuqP1XY6L6fI4GtQRAlQLAJ9fzlfiFObK0MxxaElThJnVbbGWiACdGSQw f8YRir4bysLeXALBme0WmPM= =nfG6 -----END PGP SIGNATURE----- --sm4nu43k4a2Rpi4c--