From nobody Wed Oct 1 09:38:50 2025 X-Original-To: dev-commits-src-branches@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cc8y272NZz69GcY; Wed, 01 Oct 2025 09:38:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cc8y24nNMz3Gpg; Wed, 01 Oct 2025 09:38:50 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759311530; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6wAofoBtxi1LQ3+n7q4PVZhOeLRETP6wQ+jmvPo9tAU=; b=nJKw6d0lxdjDEN+/AGMGzKG35eeNzxzfu21mBjK9EGTe3Q9WpMmcL+eXzFNtJwPH6kzQNW dAeLlQ9A1urRsppyStQi+UB637Ceyekw/ItxndSvEnhGBzHjTGipI/GT+F+a+H1owxOQz5 JgXHrLd/J8VRDhXFyLX0TbqRDLCJer4wNiYh3ZmpLbNNZCTm7nrreSYzrmoe+TwMZN+JhG 4SFf29CUvL77ohgmLtKR+ju0b/69Jr8fATLKhRcZvUjI92re4wAVAsUz++QJaCjarYHBAN ZOhm7Ut5+QQSiJMb2Glh2aVVfmqkezh/EMuTXXm4V+xz1BypwUGNrHpoqUzT4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759311530; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6wAofoBtxi1LQ3+n7q4PVZhOeLRETP6wQ+jmvPo9tAU=; b=DfpwBZ/xK0MxspNfhy0jHJ5sBSPyJ8+dnlf4qZh2dmC7md3I3Gtubu1Lm7GtxaSEP7J6G1 nzKE3Mlz0MPjokWimup8goBE4ASd4g9CCrxg82/JjCq3WAbWbg3w1N2S8qvU+wD5NUEMly KwiyDDprafrynD53Nr8Es4dXujaBoZYzz/Ajx+1LHWFlWREQkDXAsnxf7UB2hyWGIwvElb zjMcSf8gRwPOPDC7hLXOXbyefeLW4UUo21Nf5ZdzLwazl9oKkCteMhgi9yksny7DerXbZM b/o3tPnKkbWYvfH2WfcP4Rkx/2nH6eJneJpwF1eaOpZXFgRyrEWs+j6NqGliFg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1759311530; a=rsa-sha256; cv=none; b=igullq11K0mn7IG+2E9wyG5SDYkLaZGGdp3v4HFwrY5D5WR+yUWF4cJiGhhtBSQemaQZ0Z f2uRbDYaR0oxuPAAwKUG9lGyvW1RNf/w5I8v8zzBfVk6fpJ1Cw+WTuNGrSnug841I2nd09 InmZLf/pBUsgfBMykKT7U8PNMCwiPtx+6R1XZUtUL5UF+SJyPhHL0vLtrMIfI477U059Dt 9Jg6LvjY8X0MqAW/Wal58U2QbSJYosSKAKAuIHif+B5R74B/4IQ2qNqS89bs/P85P9jhfh 6APJwbsA3AeJf0w7S7eM+YhU3oWT5Icje02i8Z8LSrYSUBrIotkURcsA48XZNQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4cc8y24KjJz2Gl; Wed, 01 Oct 2025 09:38:50 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 5919coIJ016482; Wed, 1 Oct 2025 09:38:50 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 5919coZf016479; Wed, 1 Oct 2025 09:38:50 GMT (envelope-from git) Date: Wed, 1 Oct 2025 09:38:50 GMT Message-Id: <202510010938.5919coZf016479@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Ahmad Khalifa Subject: git: e05342f3618f - stable/14 - ng_tty: don't increment m_data List-Id: Commits to the stable branches of the FreeBSD src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-branches List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-branches@freebsd.org Sender: owner-dev-commits-src-branches@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: vexeduxr X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: e05342f3618f0e7b0e6c75a513212b389714d59a Auto-Submitted: auto-generated The branch stable/14 has been updated by vexeduxr: URL: https://cgit.FreeBSD.org/src/commit/?id=e05342f3618f0e7b0e6c75a513212b389714d59a commit e05342f3618f0e7b0e6c75a513212b389714d59a Author: Ahmad Khalifa AuthorDate: 2025-09-24 15:01:57 +0000 Commit: Ahmad Khalifa CommitDate: 2025-10-01 08:34:47 +0000 ng_tty: don't increment m_data Stop incrementing m_data so the callee can read the mbuf. MFC after: 3 days Reviewed by: glebius Differential Revision: https://reviews.freebsd.org/D52702 (cherry picked from commit 57d5a8feda3fd25a650eaab5998db13633d62d2d) --- sys/netgraph/ng_tty.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sys/netgraph/ng_tty.c b/sys/netgraph/ng_tty.c index 6f8667c664bb..c7d8a1b64eac 100644 --- a/sys/netgraph/ng_tty.c +++ b/sys/netgraph/ng_tty.c @@ -485,9 +485,7 @@ ngt_rint(struct tty *tp, char c, int flags) } /* Add char to mbuf */ - *mtod(m, u_char *) = c; - m->m_data++; - m->m_len++; + *(u_char *)mtodo(m, m->m_len++) = c; m->m_pkthdr.len++; /* Ship off mbuf if it's time */