From owner-cvs-all Mon Oct 21 6:46:59 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 64BAA37B401; Mon, 21 Oct 2002 06:46:58 -0700 (PDT) Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163]) by mx1.FreeBSD.org (Postfix) with ESMTP id E638D43E42; Mon, 21 Oct 2002 06:46:56 -0700 (PDT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost [127.0.0.1]) by critter.freebsd.dk (8.12.6/8.12.6) with ESMTP id g9LDksn4002142; Mon, 21 Oct 2002 15:46:54 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: "Greg 'groggy' Lehey" Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/i386/i386 db_trace.c machdep.c src/sys/i386/include reg.h In-Reply-To: Your message of "Mon, 21 Oct 2002 15:54:47 +0930." <20021021062447.GA63728@wantadilla.lemis.com> Date: Mon, 21 Oct 2002 15:46:54 +0200 Message-ID: <2141.1035208014@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG In message <20021021062447.GA63728@wantadilla.lemis.com>, "Greg 'groggy' Lehey" writes: >On Sunday, 20 October 2002 at 13:48:56 -0700, Poul-Henning Kamp wrote: >> phk 2002/10/20 13:48:56 PDT >> >> Modified files: >> sys/i386/i386 db_trace.c machdep.c >> sys/i386/include reg.h >> Log: >> Change the definition of the debugging registers to be an array, so >> that we can index into it, rather than do pointer gymnastics on a >> structure containing 8 elements. >> >> Verified by: MD5 hash on the produced .o files. > >Not verified by: make world. > >This breaks world in a couple of places in lib/libc. I've added the >following to my local copy of the file: > >#define dr6 dr[6] >#define dr7 dr[7] > >It's not clear that this is the correct solution, so I haven't >committed it. It may actually be a good idea for those particular registers since that would allow us to keep the GDB file on the vendor-branch (Well, put it back using repo-surgery...) -- Poul-Henning Kamp | UNIX since Zilog Zeus 3.20 phk@FreeBSD.ORG | TCP/IP since RFC 956 FreeBSD committer | BSD since 4.3-tahoe Never attribute to malice what can adequately be explained by incompetence. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message