From nobody Tue Apr 1 14:26:15 2025 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZRr0724c4z5rc0f for ; Tue, 01 Apr 2025 14:26:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZRr071f3Bz3q0m for ; Tue, 01 Apr 2025 14:26:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1743517575; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z6oYjFjWBwS5jGU8LH/dahyPk32LH/PX+fYC0jfVwFQ=; b=CnXyqLbb6MtFlwpTuTZU6WrD8lx3EowiXOvMx3JbdT7clRKI1XDVb+lKnmX8j7O1BS/7Nd psT7R5b7utQP1oFz3YaNP6v381/VEge9iRHTqORfTL4Kdr0xN5w/OogQLs/wRq11DS77pc 0CpX1x7plYU/5tqeS1GMmc85E5OJZLUgVekPLg9/YuSrM0eDsrhirK+NNlIzPcbfCqn9AD 4LHcyQM5HEufzhb+80lzr+NC5hMidJ+f2I5rpAIUBBPBzOaHUir129kJ0lwSJlYTEPIQQd v9g7FoaAIMadRoXE2K2HY0Zm2ngxpFxeUWjZcR5D3nSZ/37oQtaJX8ehcB6ryQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1743517575; a=rsa-sha256; cv=none; b=vfUj1bJ1s+CvEbnAzNZuiv4ddgClXwA6kOjE0K0OLtuza/CU64hEqipyqAPu2SGMtbd3d2 PDH8+auhXvK7lfDJRNdQwehyDbI4jEXsK0LtMSJJUdB30vDhfuxROXvSjXvvaxYWw8uu8Z NiAPeswyJp8oSLt6/g0jzabjoYGBtW9QxAhYP5X1TCPta9CmVh5iNzcbmufYh8BkJ/T9rk 4SEmsiTkrVjTeAfRxcZeQSCXYbQv4RPvReJlC9U3F7foNJHxPKRiWIojGvP4AfO3qxPtsO 7vHvgCJV3i7RkpBI02mqkKOW0zjOe9GII46GhGH9LKy01zcHJIPna2VNJwHRCA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1743517575; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Z6oYjFjWBwS5jGU8LH/dahyPk32LH/PX+fYC0jfVwFQ=; b=VKRg+YQWhbcEpBc0VCPi62O+H7SAKvpmAjQLinmFfATX04+32ljYWo/LA9vlafI2Cc0a8j Yq1mjvgjDPNS2VMrwtjvJXt6+jH+ISXBsWI0LseqzdiuO5WzYwbzEdqY2yVlH8mvt/2hXE 0+QmiTvSxHP2v7mwO9rsZ0J5rdiAuvWLtsZANQ73x8/ET2gX8FGXLhg8KWFGPc95tW7rzR 3hgQZ/9Fre7TkIM3Th29BfcBlgn35/NboQJQ/F+aJF7bgBZxAZqLmliLz9o5II7+P9yfzs 34ENooWdJhdKGCw4hXn5M0NyxYG4ZUiXRywWAWf14vrTk4X+Kjljf46EEaPyAg== Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZRr071FDczb1m for ; Tue, 01 Apr 2025 14:26:15 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 531EQFTP081522 for ; Tue, 1 Apr 2025 14:26:15 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from bugzilla@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 531EQFqK081521 for net@FreeBSD.org; Tue, 1 Apr 2025 14:26:15 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: bugzilla set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 283426] panic in sbappendaddr_locked() - if_ovpn related? Date: Tue, 01 Apr 2025 14:26:15 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 14.2-RELEASE X-Bugzilla-Keywords: crash, regression X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: commit-hook@FreeBSD.org X-Bugzilla-Status: New X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="UTF-8" X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@FreeBSD.org MIME-Version: 1.0 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D283426 --- Comment #17 from commit-hook@FreeBSD.org --- A commit in branch main references this bug: URL: https://cgit.FreeBSD.org/src/commit/?id=3D04a7134c1e92c7752ffdc665f99ae26db= 70866c0 commit 04a7134c1e92c7752ffdc665f99ae26db70866c0 Author: Kristof Provost AuthorDate: 2025-04-01 13:19:26 +0000 Commit: Kristof Provost CommitDate: 2025-04-01 14:15:29 +0000 if_ovpn: fix use-after-free of mbuf m_unshare() can return a new mbuf pointer. We update the 'm' pointer in ovpn_udp_input(), but if we decide to pass on the packet (e.g. because = it's for an unknown peer) the caller (udp_append()) continues with the old 'm' pointer, eventually resulting in a use-after-free. Re-order operations in ovpn_udp_input() so that we don't modify the 'm' pointer until we're committed to keeping the packet. PR: 283426 Test case by: takahiro.kurosawa@gmail.com MFC after: 2 weeks Sponsored by: Rubicon Communications, LLC ("Netgate") sys/net/if_ovpn.c | 12 +++--- tests/sys/net/if_ovpn/if_ovpn.sh | 81 ++++++++++++++++++++++++++++++++++++= ++++ 2 files changed, 87 insertions(+), 6 deletions(-) --=20 You are receiving this mail because: You are the assignee for the bug.=