From owner-svn-ports-all@freebsd.org Mon Mar 20 19:29:29 2017 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 788F8D146CD; Mon, 20 Mar 2017 19:29:29 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com [74.125.82.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 140691DA7; Mon, 20 Mar 2017 19:29:28 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: by mail-wm0-f48.google.com with SMTP id n11so71690771wma.1; Mon, 20 Mar 2017 12:29:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=IOQEoWPw5IuyXgT4wosyChThFAYHbMv8BlnERSF1xEY=; b=GPPQ9Mv2adnQahg2oOfJ3iPEjWmwbRvliBgfeKsZQ5VHljdXQ3/C3q03vr7cGGeWnh ukJtaMjDxfmp5KmP3qcpcnO21BBn57HJbR8x3n7d8Kv751C2YtO9SUDjR56ya6UGkhMi LQcp64lO0q+NK6LNaWAoHiTymukr8QKk8sUTMqAkZDKR/M23W2zNvJHVEAwSnyh8C1o1 o0FzwPXVIq8UEvHzFITn3HOsWy8+NHmwiRUccfq2/Gp2OCs2v0kv4aJbKb5hGOK2XuaF eQ3oJyDDdbmXF0OXRaOU/MNbRgAA6ekVeA6WdzbaQGfozKJUiQ0gWdqFBcxoA/NZeywQ JEmQ== X-Gm-Message-State: AFeK/H00dngX7OX4eu8p7F1UOdqqO+hEz6dt24AuQ4PBE75VblgQ+LlIKw+WRBlakUwE7g== X-Received: by 10.28.156.140 with SMTP id f134mr4631967wme.40.1490037673935; Mon, 20 Mar 2017 12:21:13 -0700 (PDT) Received: from mail-wm0-f48.google.com (mail-wm0-f48.google.com. [74.125.82.48]) by smtp.gmail.com with ESMTPSA id o22sm21157702wro.13.2017.03.20.12.21.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 20 Mar 2017 12:21:13 -0700 (PDT) Received: by mail-wm0-f48.google.com with SMTP id n11so71539233wma.1; Mon, 20 Mar 2017 12:21:13 -0700 (PDT) X-Received: by 10.28.1.68 with SMTP id 65mr11881551wmb.63.1490037673520; Mon, 20 Mar 2017 12:21:13 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.39.134 with HTTP; Mon, 20 Mar 2017 12:20:52 -0700 (PDT) In-Reply-To: References: <201703050813.v258DSQt052933@repo.freebsd.org> From: Kyle Evans Date: Mon, 20 Mar 2017 14:20:52 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r435456 - in head: comms/wy60 deskutils/gbirthday devel/arduino-builder devel/cityhash devel/google-gdata devel/monodevelop emulators/citra games/openomf security/ssh-vault To: Mathieu Arnold Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Mar 2017 19:29:29 -0000 On Mon, Mar 20, 2017 at 1:38 PM, Mathieu Arnold wrote: > > TL:DR; You should never use GH_ACCOUNT/GH_PROJECT/GH_TAGNAME in > GH_SUBDIR because they get messed up with during processing. > > When reading the following, you may want to read Mk/bsd.sites.mk, > starting around line 400. > > The default values of the GH_(ACCOUNT|PROJECT|TAGNAME) variables have an > implied :DEFAULT group, which is the default group. So, when you write: > > GH_ACCOUNT= foo > > it ends up being: > > GH_ACCOUNT= foo:DEFAULT > > It is building on top of multiple distfiles feature explained here: > https://www.freebsd.org/doc/en/books/porters-handbook/makefile-distfiles.html#porting-master-sites-n > > They can contain multiple values, and in fact, GH_TUPLE is only a > syntastic sugar on top of them, so, when GH_TUPLE is processed, its > content is hammered and sawed to fit into them. > > Then, for each group variables get filled in, so, if you have > > GH_ACCOUNT= foo bar:extra > > it'll generate > > GH_ACCOUNT_DEFAULT= foo > GH_ACCOUNT_extra= bar > > and if you write: > > GH_ACCOUNT= foo > GH_TUPLE= bar:bar:v1.0:extra/bar > > At one point, GH_ACCOUNT will contain "foo bar:extra" and then the same > two variables describe above will be filled. > Excellent! Thank you for that explanation -- that makes a lot more sense. It wasn't immediately obvious to me while looking at things how GH_ACCOUNT could get clobbered, I wasn't thinking of (or looking for) this kind of magic. Duly noted. Thanks, Kyle Evans