From owner-freebsd-stable@freebsd.org Wed Mar 22 03:55:10 2017 Return-Path: Delivered-To: freebsd-stable@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EF595D1799B for ; Wed, 22 Mar 2017 03:55:10 +0000 (UTC) (envelope-from jamie@dyslexicfish.net) Received: from dyslexicfish.net (deadcat.mail.dyslexicfish.net [45.63.12.202]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9918C2B1; Wed, 22 Mar 2017 03:55:10 +0000 (UTC) (envelope-from jamie@dyslexicfish.net) Received: from dyslexicfish.net (deadcat.mail.dyslexicfish.net [45.63.12.202]) by dyslexicfish.net (8.14.5/8.14.5) with ESMTP id v2M3solL034698; Wed, 22 Mar 2017 03:54:51 GMT (envelope-from jamie@dyslexicfish.net) Received: (from jamie@localhost) by dyslexicfish.net (8.14.5/8.14.5/Submit) id v2M3sgKO034696; Wed, 22 Mar 2017 03:54:42 GMT (envelope-from jamie) From: Jamie Landeg-Jones Message-Id: <201703220354.v2M3sgKO034696@dyslexicfish.net> Date: Wed, 22 Mar 2017 03:54:42 +0000 To: kevans91@ksu.edu, jamie@dyslexicfish.net Cc: jamie@catflap.org, freebsd-stable@freebsd.org, emaste@freebsd.org Subject: Re: Freebsd 11 - /usr/bin missing [xl]zgrep/zegrep/zfgrep References: <201703220233.v2M2X8Jg033781@dyslexicfish.net> In-Reply-To: User-Agent: Heirloom mailx 12.4 7/29/08 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.2.7 (dyslexicfish.net [45.63.12.202]); Wed, 22 Mar 2017 03:54:51 +0000 (GMT) X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Mar 2017 03:55:11 -0000 Kyle Evans wrote: > > > > Am I really the first to notice, or am I missing something here? > > Yes, but only slightly. =) If you do `grep -V`, you should find that > your system is actually using GNU grep. Please refer to: > https://svnweb.freebsd.org/base/head/gnu/usr.bin/grep/ -- this one > doesn't actually install these links at all, because the source > doesn't support these invocations. See grep.c:1368-ish in my link. > > > Unless bsdgrep is set to be installed as "grep" (instead of GNU grep), these 6 hard links, > > and associated manual page hard links are not created. > > This is only half-true, given the above section. =) I'd like to help > change this at some point and have done some work to try to improve > bsdgrep, but I've not been finding time to poke emaste@ to see if I > can help with getting some of my work integrated. Wow! Thanks for the quick reply! I wasn't too clear. I realise the default grep is GNU grep, and that it doesn't have the lzma-grepping support, and hence the gnu grep doesn't install these links. However, in this case (WITH_BSD_GREP not defined), GNU grep is installed as expected, but BSD grep is still installed, but instead as "bsdgrep". Prior to this change, the links were made against the installed "grep" if WITH_BSD_GREP was defined, but if WITH_BSD_GREP wasn't defined, they were *still* created, but linked instead to "bsdgrep". Now, they are only created in the former case. I.E. By default, on FreeBSD 10, GNUgrep existed as "grep" and xzgrep etc... existed as hard links to "bsdgrep". On FreeBSD 11, those links are not created, despite "bsdgrep" still being installed. I realise there are advantages of GNUgrep and also advantages of BSDgrep, hence why they are currently both available (and thanks for your work on getting bsd grep up to parity) but I don't understand why on the default install, xzgrep.. etc. are no longer linked to bsdgrep, unless there are problems with them? (I notice the 32K limit bug has been fixed) - but then if there were problems, they wouldn;t be linked whatever the configured system "grep" Hope this makes sense, I should have been asleep hours ago! Cheers, Jamie