Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 04 May 2015 23:39:56 +0000
From:      bugzilla-noreply@freebsd.org
To:        freebsd-ports-bugs@FreeBSD.org
Subject:   [Bug 199938] games/wxlauncher: drop DISTNAME hack for USE_GITHUB
Message-ID:  <bug-199938-13-pKJ6Q2qWPC@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-199938-13@https.bugs.freebsd.org/bugzilla/>
References:  <bug-199938-13@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199938

lightside <lightside@gmx.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|maintainer-feedback?(lights |maintainer-feedback-
                   |ide@gmx.com)                |

--- Comment #1 from lightside <lightside@gmx.com> ---
If short, this is not a hack, because DISTNAME defined with ?= assign, which
allows to redefine it, as for many other ports. I used
${PORTNAME}-${DISTVERSIONFULL} before, which was wxlauncher-0.9.5, for example.
The same for 0.9.6 version.

If long, I disagree on what Bryan Drewery did for USE_GITHUB after ports
r381618 changes (bug 194898, comment #17 and bug 199052 for reference). In my
opinion, the DISTNAME shouldn't be changed externally from the port (but it's
more related to _GH0 suffix). I (and other users of ports) shouldn't redownload
the distfile, because of the wish (or state) of ports manager to change
DISTNAME on his own. I would prefer to use correct MASTER_SITES instead of
(new) USE_GITHUB, but this brings attention to this from reviewers (because of
dominating opinion, which explained in the Porter's Handbook), independently if
it works or not.

If return to the changes of new USE_GITHUB, the amount of bug fixing already
shows the value of it. But I don't think, that I should discuss it again.

-- 
You are receiving this mail because:
You are the assignee for the bug.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-199938-13-pKJ6Q2qWPC>