From owner-freebsd-ports-bugs@FreeBSD.ORG Mon May 4 23:39:56 2015 Return-Path: Delivered-To: freebsd-ports-bugs@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4CE87CA3 for ; Mon, 4 May 2015 23:39:56 +0000 (UTC) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1EA8B17D6 for ; Mon, 4 May 2015 23:39:56 +0000 (UTC) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id t44NdtOO081472 for ; Mon, 4 May 2015 23:39:55 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 199938] games/wxlauncher: drop DISTNAME hack for USE_GITHUB Date: Mon, 04 May 2015 23:39:56 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Individual Port(s) X-Bugzilla-Version: Latest X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Only Me X-Bugzilla-Who: lightside@gmx.com X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: maintainer-feedback- X-Bugzilla-Changed-Fields: flagtypes.name Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 May 2015 23:39:56 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=199938 lightside changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|maintainer-feedback?(lights |maintainer-feedback- |ide@gmx.com) | --- Comment #1 from lightside --- If short, this is not a hack, because DISTNAME defined with ?= assign, which allows to redefine it, as for many other ports. I used ${PORTNAME}-${DISTVERSIONFULL} before, which was wxlauncher-0.9.5, for example. The same for 0.9.6 version. If long, I disagree on what Bryan Drewery did for USE_GITHUB after ports r381618 changes (bug 194898, comment #17 and bug 199052 for reference). In my opinion, the DISTNAME shouldn't be changed externally from the port (but it's more related to _GH0 suffix). I (and other users of ports) shouldn't redownload the distfile, because of the wish (or state) of ports manager to change DISTNAME on his own. I would prefer to use correct MASTER_SITES instead of (new) USE_GITHUB, but this brings attention to this from reviewers (because of dominating opinion, which explained in the Porter's Handbook), independently if it works or not. If return to the changes of new USE_GITHUB, the amount of bug fixing already shows the value of it. But I don't think, that I should discuss it again. -- You are receiving this mail because: You are the assignee for the bug.