From owner-freebsd-testing@FreeBSD.ORG Thu May 28 16:34:30 2015 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D9DDFA2B; Thu, 28 May 2015 16:34:30 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-oi0-x236.google.com (mail-oi0-x236.google.com [IPv6:2607:f8b0:4003:c06::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id A03308B7; Thu, 28 May 2015 16:34:30 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by oiww2 with SMTP id w2so36629536oiw.0; Thu, 28 May 2015 09:34:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc:content-type; bh=3vU/0nAq0QsQamwN+AAHd+fygjfmuDo/AcztQH7g2jk=; b=cqnPxku6rOxrZZcFth559h0Zcr9E6iUT4hBXfvzq084lOct8PX6VorMLM5WWqFcd2N NLa05Y5yS5p40enI71ulSF6uXpndvkcGYpsl0BXGKwa79FSWRp106IoKVMDNkb5IyDag /0ZwewRbHqzsyjL9W+dcLfYRxwHLr6E4zvhtLopJ3PfwYpYBQc1MPjco+UCSX0JK4Wad EA+fiL6Q2xh9X07/dHhdmuWKGq91sfMcXNiKO6iyWFGyFXRHPm7DOroBWKLnv90QO7Bv fz/9ph7QoMjU6LVqId2fhKmbs8mo+WqdMy+FYQJjZnpv39j8aETALhNCd11TGmsylwZk V9sA== MIME-Version: 1.0 X-Received: by 10.60.81.98 with SMTP id z2mr3260272oex.37.1432830869921; Thu, 28 May 2015 09:34:29 -0700 (PDT) Sender: asomers@gmail.com Received: by 10.202.107.3 with HTTP; Thu, 28 May 2015 09:34:29 -0700 (PDT) In-Reply-To: <556725BB.2040805@freebsd.org> References: <55670C5A.6080500@FreeBSD.org> <556725BB.2040805@freebsd.org> Date: Thu, 28 May 2015 10:34:29 -0600 X-Google-Sender-Auth: kDbWhpInLkezXFQiGNV5-OMioBw Message-ID: Subject: Re: Need help reducing compilation warnings in CURRENT From: Alan Somers To: Allan Jude Cc: "freebsd-testing@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 28 May 2015 16:34:30 -0000 On Thu, May 28, 2015 at 8:27 AM, Allan Jude wrote: > On 2015-05-28 08:38, Johannes Jost Meixner wrote: >> Hi Craig, >> >> I'll gladly help (good excuse to learn C), but looking at those errors >> in general, one thing pops out: >> >> The warnings are almost all in contrib/ areas. Hence, any fix might >> want to probably be submitted to upstream first. >> >> Correct me if I'm missing something obvious here please ;-) >> >> -J >> >> On 05/28/2015 09:30, Craig Rodrigues wrote: >>> Hi, >> >>> I've configured Jenkins to highlight compiler warnings and generate >>> a table. Jenkins also keeps track of new compiler warnings over >>> time. See: >> >>> https://jenkins.freebsd.org/job/FreeBSD_HEAD/warnings7 >> >>> Can anyone help improve the code by periodically looking at this >>> table and submitting patches to clean up the code? >> >>> Cleaning up compiler warnings is always boring work, but it is good >>> to clean up the code over time. >> >>> -- Craig _______________________________________________ >> > > Johannes has a point, it probably makes sense to exclude contrib/ and > cddl/ from the warnings tracking. I agree about contrib. But don't exclude all of cddl/, just exclude cddl/contrib. -Alan with one l > > -- > Allan Jude >