From owner-freebsd-current@FreeBSD.ORG  Wed Sep 17 00:07:32 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id CF17416A4B3
	for <current@freebsd.org>; Wed, 17 Sep 2003 00:07:32 -0700 (PDT)
Received: from phk.freebsd.dk (phk.freebsd.dk [212.242.86.175])
	by mx1.FreeBSD.org (Postfix) with ESMTP id AC5B143FCB
	for <current@freebsd.org>; Wed, 17 Sep 2003 00:07:31 -0700 (PDT)
	(envelope-from phk@phk.freebsd.dk)
Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.86.163])
	by phk.freebsd.dk (8.12.8/8.12.8) with ESMTP id h8H77QV3069265;
	Wed, 17 Sep 2003 07:07:26 GMT
	(envelope-from phk@phk.freebsd.dk)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.12.9/8.12.9) with ESMTP id h8H77O6f024375;
	Wed, 17 Sep 2003 09:07:26 +0200 (CEST)
	(envelope-from phk@phk.freebsd.dk)
To: Bruce Evans <bde@zeta.org.au>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Tue, 16 Sep 2003 10:42:38 +1000."
             <20030916102534.J2924@gamplex.bde.org> 
Date: Wed, 17 Sep 2003 09:07:24 +0200
Message-ID: <24374.1063782444@critter.freebsd.dk>
cc: current@freebsd.org
cc: Kris Kennaway <kris@obsecurity.org>
Subject: Re: panic: Negative bio_offset (-15050100712783872) on bio
	0xc7725d50 
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 17 Sep 2003 07:07:32 -0000

In message <20030916102534.J2924@gamplex.bde.org>, Bruce Evans writes:

>This is either disk corruption or an ffs bug.  ffs passes the garbage
>block number 0xffffe5441ae9720 to bread.  GEOM then handles this austerely
>by panicing.  Garbage block numbers, including negative ones, can possibly
>be created by applications seeking to preposterous offsets, so they should
>not be handled with panics.

They most certainly should!  If the range checking in any filesystem
is not able to catch these cases I insist that GEOM do so with a panic.

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.