From owner-cvs-all@FreeBSD.ORG Mon Nov 17 15:25:55 2003 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5A9BF16A4CE for ; Mon, 17 Nov 2003 15:25:55 -0800 (PST) Received: from floyd.stormweb.net (floyd.stormweb.net [65.39.129.201]) by mx1.FreeBSD.org (Postfix) with ESMTP id 3540B43FBF for ; Mon, 17 Nov 2003 15:25:49 -0800 (PST) (envelope-from abuse@stormweb.ca) Received: (qmail 32189 invoked by uid 110); 17 Nov 2003 23:25:48 -0000 Received: (qmail 32173 invoked from network); 17 Nov 2003 23:25:47 -0000 Received: from mx2.freebsd.org (216.136.204.119) by floyd.stormweb.net with SMTP; 17 Nov 2003 23:25:47 -0000 Received: from hub.freebsd.org (hub.freebsd.org [216.136.204.18]) by mx2.freebsd.org (Postfix) with ESMTP id E211A567A8 for ; Mon, 17 Nov 2003 15:25:44 -0800 (PST) (envelope-from owner-src-committers@FreeBSD.org) Received: by hub.freebsd.org (Postfix) id D5FE516A513; Mon, 17 Nov 2003 15:25:41 -0800 (PST) Received: by hub.freebsd.org (Postfix, from userid 538) id 2FCBA16A4D1; Mon, 17 Nov 2003 15:25:40 -0800 (PST) Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D9ECA16A4CE; Mon, 17 Nov 2003 15:25:07 -0800 (PST) Received: from VARK.homeunix.com (adsl-68-123-40-77.dsl.pltn13.pacbell.net [68.123.40.77]) by mx1.FreeBSD.org (Postfix) with ESMTP id 9673343FD7; Mon, 17 Nov 2003 15:25:02 -0800 (PST) (envelope-from das@FreeBSD.ORG) Received: from VARK.homeunix.com (localhost [127.0.0.1]) by VARK.homeunix.com (8.12.9/8.12.9) with ESMTP id hAHNNHen056133; Mon, 17 Nov 2003 15:23:17 -0800 (PST) (envelope-from das@FreeBSD.ORG) Received: (from das@localhost) by VARK.homeunix.com (8.12.9/8.12.9/Submit) id hAHNNHw2056132; Mon, 17 Nov 2003 15:23:17 -0800 (PST) (envelope-from das@FreeBSD.ORG) Date: Mon, 17 Nov 2003 15:23:16 -0800 From: David Schultz To: Wes Peters Message-ID: <20031117232316.GA56085@VARK.homeunix.com> Mail-Followup-To: Wes Peters , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <200311170639.hAH6dduA076667@repoman.freebsd.org> <200311171301.45679.wes@softweyr.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200311171301.45679.wes@softweyr.com> Sender: owner-src-committers@FreeBSD.org Precedence: bulk X-Loop: FreeBSD.ORG X-SpamGuard: checked X-SpamScore: 0.0|10 cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sbin/nologin Makefile nologin.c nologin.sh X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.1 List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Nov 2003 23:25:55 -0000 On Mon, Nov 17, 2003, Wes Peters wrote: > On Sunday 16 November 2003 22:39, David Schultz wrote: > > das 2003/11/16 22:39:39 PST > > > > FreeBSD src repository > > > > Modified files: > > sbin/nologin Makefile > > Added files: > > sbin/nologin nologin.c > > Removed files: > > sbin/nologin nologin.sh > > Log: > > Reimplement nologin(8) as a C program. This allows us to > > statically link it at low cost and avoid environment poisoning > > attacks associated with LD_LIBRARY_PATH. > > I suppose adding the logging done by the sysutils/no-login port would > make the program objectionably large. Sigh. Several times over the > past five years I considering asking if we should just import my > nologin and be done with it; each time I didn't pursue it because it > wasn't worth the bikeshed. I was only interested in fixing the recently introduced security hole; I didn't bother trying to add new features at the same time. Logging would be a nice enhancement, though. Personally, I don't think that a few kilobytes of disk space are a reasonable concern, except for embedded systems that don't use nologin anyway. If nologin(8) were moved to /usr/sbin, perhaps people would be more willing to accept the increased footprint. After all, there is no real reason for it to be in /sbin; it isn't required in order to log in or mount /usr. ;-)