From owner-freebsd-tcltk@freebsd.org Tue Nov 10 16:12:10 2015 Return-Path: Delivered-To: freebsd-tcltk@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CBDFAA2BAF2 for ; Tue, 10 Nov 2015 16:12:10 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mailman.ysv.freebsd.org (mailman.ysv.freebsd.org [IPv6:2001:1900:2254:206a::50:5]) by mx1.freebsd.org (Postfix) with ESMTP id A68471175 for ; Tue, 10 Nov 2015 16:12:10 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by mailman.ysv.freebsd.org (Postfix) id A50E9A2BAEE; Tue, 10 Nov 2015 16:12:10 +0000 (UTC) Delivered-To: tcltk@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8973FA2BAED; Tue, 10 Nov 2015 16:12:10 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wm0-x235.google.com (mail-wm0-x235.google.com [IPv6:2a00:1450:400c:c09::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 22A721173; Tue, 10 Nov 2015 16:12:10 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by wmww144 with SMTP id w144so7268222wmw.0; Tue, 10 Nov 2015 08:12:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=gPqXue4glG7mR5MmrhGgYJfAs5JqTqWPEuiQk+Yd8Ik=; b=e+T5k1/VblgdQBLkh9Df1JnNq3j9P9qLhgtUPswb87LAohArH/YbjY0CYupJcTtYdE qL9h7Gp7ypUWVzXR1Kn9yJ3d70wG290YwXZ303y1PmYO5dVtDUMWwz7yTiDsEx3vROMD LeI4VJucq7ePI+iWV1SCEO1GujDLAO3tu7PpSN/Z//8tSX/R4A3fdPzCmcJtpmgJDwzx eXSRaCiFaWdcE7vTwUDkWIsmrdSnAnb4RHxW71u77ddN5jDoFB7HDNyi1EZ62Z0in9ek OBq4BjP26A2/bNIOBu9/7S32s6R7rYJ61a+YgnO/v3/WtG/3uJeRDaZ6A7Y76Yt4IQsJ NYZw== X-Received: by 10.28.229.212 with SMTP id c203mr30979745wmh.11.1447171927743; Tue, 10 Nov 2015 08:12:07 -0800 (PST) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by smtp.gmail.com with ESMTPSA id w66sm4841068wme.11.2015.11.10.08.12.06 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Nov 2015 08:12:06 -0800 (PST) Sender: Baptiste Daroussin Date: Tue, 10 Nov 2015 17:12:04 +0100 From: Baptiste Daroussin To: Andrey Chernov Cc: tcltk@FreeBSD.org, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r290637 - head/lib/libc/locale Message-ID: <20151110161204.GM10134@ivaldir.etoilebsd.net> References: <201511100811.tAA8BR0R034338@repo.freebsd.org> <5641E7B4.2070508@freebsd.org> <20151110130430.GK10134@ivaldir.etoilebsd.net> <5641EF26.8060600@freebsd.org> <20151110133615.GL10134@ivaldir.etoilebsd.net> <5642163E.1050405@freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="OGW1Z2JKiS9bXo17" Content-Disposition: inline In-Reply-To: <5642163E.1050405@freebsd.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-BeenThere: freebsd-tcltk@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: FreeBSD-specific Tcl/Tk discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Nov 2015 16:12:10 -0000 --OGW1Z2JKiS9bXo17 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Nov 10, 2015 at 07:07:26PM +0300, Andrey Chernov wrote: > On 10.11.2015 16:36, Baptiste Daroussin wrote: > > On Tue, Nov 10, 2015 at 04:20:38PM +0300, Andrey Chernov wrote: > >> On 10.11.2015 16:04, Baptiste Daroussin wrote: > >>> On Tue, Nov 10, 2015 at 03:48:52PM +0300, Andrey Chernov wrote: > >>>> On 10.11.2015 11:11, Baptiste Daroussin wrote: > >>>>> Author: bapt > >>>>> Date: Tue Nov 10 08:11:27 2015 > >>>>> New Revision: 290637 > >>>>> URL: https://svnweb.freebsd.org/changeset/base/290637 > >>>>> > >>>>> Log: > >>>>> return "US-ASCII" instead of "POSIX" for "C" and "POSIX" locales > >>>>> as it used to be in previous version of the locales. Returning > >>>>> "POSIX" has too many fallouts. > >>>> > >>>> You can return "ANSI_X3.4-1968" (another name of "US-ASCII") to be > >>>> different with real US-ASCII. It is what glibc returns for C/POSIX > >>>> locale and most ports expected, being linux-oriented. > >>>> > >>> I thought about it, but in the end it is probably safer for now that = nl_langinfo > >>> return US-ASCII as it did in the past, to reduce breakage with FreeBS= D only code > >>> that maybe be existing ou there. > >> > >> All FreeBSD code I know never check locale this way. IMHO probability = of > >> potential danger to meet some linux-oriented port with this check is > >> much much higher than to meet similar FreeBSD only code in the wild. In > >> any case, changing collate order from A-Za-z to aA-zZ we do just now > >> have much higher probability to break unknown FreeBSD only code, so one > >> breaking change can go with other one together. > >> > > That is true, except that the new collation thing is invalidated as soo= n as you > > set LC_COLLATE=3DC which bring your back to A-Za-z. So you have a worka= round while > > changing the return value of nl_langinfo() is not workaroundable. >=20 > Well, forget my improper comparison with collate and see this bug in > action right now, in our port tcl8.6.4/unix/tclUnixInit.c: >=20 > See localeTable and comment above it, there is internal "ansi_x3.4-1968" > (i.e. POSIX locale), internal "ascii" and even no alias for our > "us-ascii" at all. >=20 > It gets info through nl_langinfo(CODESET), lowercased. I.e. not using > "ANSI_X3.4-1968" breaks all tcl ports right now, this is more essential > than hypothetical private FreeBSD only code no one see. That one is a valid point, that also means that is is broken right now on FreeBSD 10 and below? Best regards, Bapt --OGW1Z2JKiS9bXo17 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlZCF1QACgkQ8kTtMUmk6EyP/QCfWiV1aNhs9KSkUD9jju/7ms0L KXYAnRYIik2hzCtx9XwqnBHg1Tzl4GG/ =ZF+g -----END PGP SIGNATURE----- --OGW1Z2JKiS9bXo17--