From owner-freebsd-wireless@freebsd.org  Fri Jan 20 06:15:44 2017
Return-Path: <owner-freebsd-wireless@freebsd.org>
Delivered-To: freebsd-wireless@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 82DF0CB9A8C
 for <freebsd-wireless@mailman.ysv.freebsd.org>;
 Fri, 20 Jan 2017 06:15:44 +0000 (UTC)
 (envelope-from kevlo@ns.kevlo.org)
Received: from ns.kevlo.org (220-135-115-6.HINET-IP.hinet.net [220.135.115.6])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits))
 (Client CN "ns.kevlo.org", Issuer "ns.kevlo.org" (not verified))
 by mx1.freebsd.org (Postfix) with ESMTPS id EF1F51FB3
 for <freebsd-wireless@freebsd.org>; Fri, 20 Jan 2017 06:15:43 +0000 (UTC)
 (envelope-from kevlo@ns.kevlo.org)
Received: from ns.kevlo.org (localhost [127.0.0.1])
 by ns.kevlo.org (8.15.2/8.15.2) with ESMTPS id v0K6EAEj053467
 (version=TLSv1.2 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);
 Fri, 20 Jan 2017 14:14:11 +0800 (CST)
 (envelope-from kevlo@ns.kevlo.org)
Received: (from kevlo@localhost)
 by ns.kevlo.org (8.15.2/8.15.2/Submit) id v0K6E9R7053466;
 Fri, 20 Jan 2017 14:14:09 +0800 (CST) (envelope-from kevlo)
Date: Fri, 20 Jan 2017 14:14:09 +0800
From: Kevin Lo <kevlo@FreeBSD.org>
To: Andriy Voskoboinyk <s3erios@gmail.com>
Cc: freebsd-wireless@freebsd.org
Subject: Re: Add support for Realtek RTL8192EU
Message-ID: <20170120061409.GA53454@ns.kevlo.org>
References: <20170119083643.GA30454@ns.kevlo.org> <op.yub51oebiew4ia@localhost>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <op.yub51oebiew4ia@localhost>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-BeenThere: freebsd-wireless@freebsd.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Discussions of 802.11 stack,
 tools device driver development." <freebsd-wireless.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-wireless>, 
 <mailto:freebsd-wireless-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-wireless/>
List-Post: <mailto:freebsd-wireless@freebsd.org>
List-Help: <mailto:freebsd-wireless-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-wireless>, 
 <mailto:freebsd-wireless-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 20 Jan 2017 06:15:44 -0000

On Fri, Jan 20, 2017 at 01:26:37AM +0200, Andriy Voskoboinyk wrote:
> 
> Thu, 19 Jan 2017 10:36:43 +0200 було написано Kevin Lo <kevlo@freebsd.org>:
> 
> Hi Kevin,

Hi Andriy,

> thanks for the patch! few notes to it:
> - r92c_llt_write() seems to be used only in r92c_llt_init(); so,
> it may be called without sc->sc_llt_write indirection from it;
> - you can set rate for beacon directly in r12a_beacon_init()
> (it will be overridden anyway by r12a_beacon_set_rate()) and drop
> r92e_beacon_init() wrapper.

Fixed.  Thank you for the review :)

> Are there some plans for merging it to -HEAD?

I'd like to commit it next Tuesday, thanks.

> 
> > Hi,
> >
> > This adds support for the RTL8192EU Realtek wireless chipset:
> > https://people.freebsd.org/~kevlo/rtwn-rtl8192eu.diff
> >
> > Tested in station mode with D-Link DWA-131 rev E1 on amd64.
> >
> > 	Kevin