From nobody Wed Jul 22 13:41:28 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4h4wQJ6ZQpz6m8dl for ; Wed, 22 Jul 2026 13:41:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "YR1" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4h4wQJ5d1Mz3ZTW for ; Wed, 22 Jul 2026 13:41:28 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1784727688; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kpSh8KvwEA7yWlT3SmEgqbnrDHuNEW2cVmmE61txzKI=; b=x8FHpIV2oD5jRPuvUH/uedKXx17Xt3ec7FkcrePVQ6gcaItCKsUDKenIOiSNXGqZvQRIeL hqosk6qAOPVh9wpjYD+8/lkacZHF5Uv3CFF73AziSfuv4VEGln4wUg+1bl039dQB1nD5Qt yr5/dIPL9KSeCRdF4ckish8TaieufXgWmPr7pRPIogvARPkSXXCORGNlcj32lrUbqQKPDx my64dTEgs4qiSUEq/0rc3/gv/5rq5wTMbUgoNOQQnkFveNPATVVwZYMDyEms5Hlz8Gh3lA sfrZcPK817fxY43Dy+u8bMtxtEaNuMhZQEUwwMvT7/z9bmxiz6krKpajr7dytA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1784727688; a=rsa-sha256; cv=none; b=KVm8MslPsOILzCT8ooRXigrbd16DABnIwWrcJiWYsnv+gRg5VuNfaBJ0NAtSOLcrv3ClVR yP2lcLDkYbK42tMteAZUOjMrIkaas/RGezY8tNf13L7bjbi/K6uBbUrh2WTDsX5we6SWI+ bnoPhALuxJC0rRevgb5IgEEJZA4LYbyf1n4YXDtkYobxeFWefPKI8lhtWYtcUBWo43AJh0 uAAKileZUnRxj+0JI+EKmC20EpijsJTAaCPfSov0r2ykTJshCMjFBsVHW7HedMYLhIGNDn RaSN5glsV7wLWjEAk4c7apj4yvkF/0KT8WilvVbNGnumoZu4wwzVz7IJ+gCNvA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1784727688; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=kpSh8KvwEA7yWlT3SmEgqbnrDHuNEW2cVmmE61txzKI=; b=VysUjCw+asYNRcowYhFs1Gvq26JqveSnTa6k3XGtXlXar0/+P/vrClJm9vG5hbvCwFa/wA DzwDccwRBSZU2FUIMvc7/KaIwrzBGvBIrABu8WSsDy4fKvKRey70uCC9oW5/mE4Q0+vkLZ Va/fHT7/eND2UW7W0HFtBccpSSgSd9FbEHGaVIn2nA1DYRRCwsA0uT8u9YjTYFLZ7S/eOr jFQnyaknTdfuNdB9QnTuegEYtE0TwVexrCGLc08+MOPldCZU+rkZcdc/8enQrn0wtOFwVC R90m+MN8ZoUoVxcKv3ag0DcV7vx4bJNX36YSNBQxQinjc8c9JxQgeNRgKth7qQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4h4wQJ4M5Zz533 for ; Wed, 22 Jul 2026 13:41:28 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 2381a by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Wed, 22 Jul 2026 13:41:28 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Siva Mahadevan Subject: git: 3e946566c134 - main - tests/exterr_test: use ATF_REQUIRE_FEATURE to check exterr_strings List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: siva X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3e946566c134e039f9c777eaa1232a32e383692c Auto-Submitted: auto-generated Date: Wed, 22 Jul 2026 13:41:28 +0000 Message-Id: <6a60c888.2381a.12193b83@gitrepo.freebsd.org> The branch main has been updated by siva: URL: https://cgit.FreeBSD.org/src/commit/?id=3e946566c134e039f9c777eaa1232a32e383692c commit 3e946566c134e039f9c777eaa1232a32e383692c Author: Siva Mahadevan AuthorDate: 2026-07-22 01:27:11 +0000 Commit: Siva Mahadevan CommitDate: 2026-07-22 13:40:53 +0000 tests/exterr_test: use ATF_REQUIRE_FEATURE to check exterr_strings This keeps the skipped test message consistent with others. Reviewed by: netchild MFC after: 3 days Sponsored by: The FreeBSD Foundation --- tests/sys/kern/Makefile | 2 ++ tests/sys/kern/exterr_test.c | 5 +++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/tests/sys/kern/Makefile b/tests/sys/kern/Makefile index f7f5d1825e01..f025172c8388 100644 --- a/tests/sys/kern/Makefile +++ b/tests/sys/kern/Makefile @@ -153,6 +153,8 @@ SRCS.subr_physmem_test+= subr_physmem_test.c subr_physmem.c CFLAGS.subr_unit.c+= -Wno-missing-prototypes SRCS.subr_unit_test+= subr_unit.c +CFLAGS.exterr_test+= -I${SRCTOP}/tests + WARNS?= 3 TESTS_SUBDIRS+= acct diff --git a/tests/sys/kern/exterr_test.c b/tests/sys/kern/exterr_test.c index 316b5b66b0e0..bde7654fecfc 100644 --- a/tests/sys/kern/exterr_test.c +++ b/tests/sys/kern/exterr_test.c @@ -34,6 +34,8 @@ #include #include +#include "freebsd_test_suite/macros.h" + /* * Pin the message format by clearing EXTERROR_VERBOSE, which would * otherwise change the output shape. @@ -66,8 +68,7 @@ ATF_TC_BODY(gettext_extended, tc) r = uexterr_gettext(exterr, sizeof(exterr)); ATF_CHECK_EQ(0, r); printf("Extended error: %s\n", exterr); - if (feature_present("exterr_strings") == 0) - atf_tc_skip("kernel built without EXTERR_STRINGS"); + ATF_REQUIRE_FEATURE("exterr_strings"); /* Note: error string may need to be updated due to kernel changes */ ATF_CHECK(strstr(exterr, " is not subset of ") != NULL); }