From owner-freebsd-testing@FreeBSD.ORG Thu Jul 24 01:12:11 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 8475C257 for ; Thu, 24 Jul 2014 01:12:11 +0000 (UTC) Received: from mail-qa0-f54.google.com (mail-qa0-f54.google.com [209.85.216.54]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 44CA82FC3 for ; Thu, 24 Jul 2014 01:12:10 +0000 (UTC) Received: by mail-qa0-f54.google.com with SMTP id k15so2186512qaq.41 for ; Wed, 23 Jul 2014 18:12:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc:content-type; bh=8SoxhiMzUQGm8VQmylbBs9BCHInA3X4wa9leUS0mM/U=; b=hR2GYqH1nBbin45nZOy2WUWOBV4+VAHEpVJl4ZFOrSXmoCtb5hBOVPEjm1hzk9xWdM 1myfubYSoNBbtJ5c9PW2c1eHz/eMXPPEUo6oDy/uydNfxqFDIbgjV9dVtxt29FFW9gRf ZGuQ5pA8abLbOjfI6Zj50+ilEqewYtMFlb3nhKbcXpvsl/7OrKEwqAVOBii05MuuNBBL +fOWpg04HYGaDhq7QWXAS2TTsdTzzhoCEyMDGataH26ASrNHWx7k5novkbeaTT2/gHFP HNqw8MbeRLnf6EbZJeGNGc6kgW60Ux+7OAYduJ5k1rgRJFThwBRaQcVYtCcfC+2X9Br5 5Fdg== X-Gm-Message-State: ALoCoQngkKhSI7a2c1QdXc/pHboJ3l6Rtw5onNOJfmCHlzk6lPT2bRaqvUtu/xkorUfeh1gtjFw8 X-Received: by 10.224.42.196 with SMTP id t4mr8655015qae.48.1406164329421; Wed, 23 Jul 2014 18:12:09 -0700 (PDT) MIME-Version: 1.0 Sender: jmmv@meroh.net Received: by 10.96.83.99 with HTTP; Wed, 23 Jul 2014 18:11:49 -0700 (PDT) X-Originating-IP: [184.153.117.174] In-Reply-To: References: From: Julio Merino Date: Wed, 23 Jul 2014 21:11:49 -0400 X-Google-Sender-Auth: 0hlQm2uROO6MOGSP7TppUkxY5s4 Message-ID: Subject: Re: Location of test kernel drivers in tree? To: Garrett Cooper Content-Type: text/plain; charset=UTF-8 Cc: "freebsd-testing@freebsd.org" X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Jul 2014 01:12:11 -0000 On Tue, Jul 22, 2014 at 7:07 PM, Garrett Cooper wrote: > Hi all, > I need to do some KPI verification and hook that into ATF / kyua. > Since we don't have RUMP [yet] from NetBSD, I would typically write a > simple, one-off test driver, hook it into the kernel build and have a > piece of C or shell code that pokes directly at the driver to get > access to kernel interfaces. > I was wondering if it made sense to put all test drivers into > sys/tests//..., e.g. > sys/tests/test_memguard/{Makefile,test_memguard.c}, etc. Is there an > alternative approach that others use to solve this problem? I don't have an answer to alternative solutions, but keeping the helper modules inside tests/sys/ (I think you got that backwards in your email?) is a good idea. (Instead of tests/sys//, I'd probably do tests/sys///... though, to keep the helpers next to the only tests that need them. Unless the helper is really generic and usable by many tests.)