From owner-freebsd-current@FreeBSD.ORG Wed Sep 28 23:15:04 2005 Return-Path: X-Original-To: current@freebsd.org Delivered-To: freebsd-current@FreeBSD.ORG Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 46B1B16A41F for ; Wed, 28 Sep 2005 23:15:04 +0000 (GMT) (envelope-from imp@BSDIMP.COM) Received: from harmony.bsdimp.com (vc4-2-0-87.dsl.netrack.net [199.45.160.85]) by mx1.FreeBSD.org (Postfix) with ESMTP id DE69D43D48 for ; Wed, 28 Sep 2005 23:15:03 +0000 (GMT) (envelope-from imp@BSDIMP.COM) Received: from localhost (localhost.village.org [127.0.0.1] (may be forged)) by harmony.bsdimp.com (8.13.3/8.13.3) with ESMTP id j8SNEHig021577; Wed, 28 Sep 2005 17:14:23 -0600 (MDT) (envelope-from imp@bsdimp.com) Date: Wed, 28 Sep 2005 17:14:17 -0600 (MDT) Message-Id: <20050928.171417.74728660.imp@bsdimp.com> To: brooks@one-eyed-alien.net From: Warner Losh In-Reply-To: <20050928200243.GA16219@odin.ac.hmc.edu> References: <20050928200243.GA16219@odin.ac.hmc.edu> X-Mailer: Mew version 3.3 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0 (harmony.bsdimp.com [127.0.0.1]); Wed, 28 Sep 2005 17:14:24 -0600 (MDT) Cc: current@freebsd.org Subject: Re: [brooks@FreeBSD.ORG: [src] cvs commit: src/etc pccard_ether] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 28 Sep 2005 23:15:04 -0000 > I've just committed the following change to /etc/pccard_ether. I think > it's the right solution, but I'm concerned it may cause problems with > drivers that incorrectly frob the IFF_UP flag themselves. If so it may > be nessicary to revert this change temporarily or at least not MFC it. This change converts the "I already have an address" check to be a "I'm up" which are two different things. dhclient leaves the interface up when it exits, even if it can't get an address. I think that might cause a lot of problems for people. I originally had this test in pccard_ether, but changed it to checking for netmask because roving from network to network didn't work without it on my laptop with multiple network interfaces. I think it will have issues on more than just these naughty drivers. Warner