From owner-svn-src-stable-9@FreeBSD.ORG Tue Jan 3 19:07:53 2012 Return-Path: Delivered-To: svn-src-stable-9@freebsd.org Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2001:4f8:fff6::35]) by hub.freebsd.org (Postfix) with ESMTP id 79ADF1065672; Tue, 3 Jan 2012 19:07:53 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from 172-17-198-245.globalsuite.net (hub.freebsd.org [IPv6:2001:4f8:fff6::36]) by mx2.freebsd.org (Postfix) with ESMTP id 3DCB71A6ECC; Tue, 3 Jan 2012 19:06:41 +0000 (UTC) Message-ID: <4F0351C0.6050103@FreeBSD.org> Date: Tue, 03 Jan 2012 11:06:40 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:9.0) Gecko/20111222 Thunderbird/9.0 MIME-Version: 1.0 To: John Baldwin References: <201112311312.pBVDCBja064475@svn.freebsd.org> <20111231140027.GA3487@reks> <4EFF16E0.7000206@t-hosting.hu> <201201030929.30656.jhb@freebsd.org> In-Reply-To: <201201030929.30656.jhb@freebsd.org> X-Enigmail-Version: undefined OpenPGP: id=1A1ABC84 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Cc: Gleb Kurtsou , src-committers@freebsd.org, svn-src-stable@freebsd.org, svn-src-all@freebsd.org, svn-src-stable-9@freebsd.org, =?ISO-8859-1?Q?G=E1bor_K=F6vesd=E1n?= , Gabor Kovesdan Subject: Re: svn commit: r229081 - stable/9/usr.bin/grep X-BeenThere: svn-src-stable-9@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for only the 9-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Jan 2012 19:07:53 -0000 On 01/03/2012 06:29, John Baldwin wrote: > On Saturday, December 31, 2011 9:06:24 am Gábor Kövesdán wrote: >> On 2011.12.31. 15:00, Gleb Kurtsou wrote: >>>> ${BINDIR}/grep ${BINDIR}/fgrep \ >>>>> ${BINDIR}/grep ${BINDIR}/zgrep \ >>>>> ${BINDIR}/grep ${BINDIR}/zegrep \ >>>>> - ${BINDIR}/grep ${BINDIR}/zfgrep \ >>>>> - ${BINDIR}/grep ${BINDIR}/xzgrep \ >>>>> - ${BINDIR}/grep ${BINDIR}/xzegrep \ >>>>> - ${BINDIR}/grep ${BINDIR}/xzfgrep \ >>>>> - ${BINDIR}/grep ${BINDIR}/lzgrep \ >>>>> - ${BINDIR}/grep ${BINDIR}/lzegrep \ >>>>> - ${BINDIR}/grep ${BINDIR}/lzfgrep >>>>> + ${BINDIR}/grep ${BINDIR}/zfgrep >>> Is there a reason we need all this mess is the first place? 12 grep links > under >>> /usr/bin. Why not to make zgrep handle all compression types. Tranparent >>> compression handling in tar was a great success. >>> >> 1, xzgrep comes from archivers/xz so scripts may be using it >> 2, the rest to follow the naming convention >> 3, auto-detection is not always trivial > > Presumably the auto-detection is more trivial than that in tar that handles > the combination of various archive formats and various compression formats. I > would definitely prefer to have a single "smart" zgrep that DTRT. I vaguely recall raising this same issue after the initial commit to HEAD, but just in case, a big +1 from me. Doug -- You can observe a lot just by watching. -- Yogi Berra Breadth of IT experience, and depth of knowledge in the DNS. Yours for the right price. :) http://SupersetSolutions.com/