From owner-svn-src-head@freebsd.org Tue Nov 27 13:45:14 2018 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BCA1A114C8EF; Tue, 27 Nov 2018 13:45:14 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 621427B435; Tue, 27 Nov 2018 13:45:14 +0000 (UTC) (envelope-from danfe@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1033) id 4CC5ED53D; Tue, 27 Nov 2018 13:45:14 +0000 (UTC) Date: Tue, 27 Nov 2018 13:45:14 +0000 From: Alexey Dokuchaev To: Steven Hartland Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r249115 - in head: sbin/camcontrol sys/sys Message-ID: <20181127134514.GA1580@FreeBSD.org> References: <201304042319.r34NJqIP040377@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201304042319.r34NJqIP040377@svn.freebsd.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 621427B435 X-Spamd-Result: default: False [1.67 / 15.00]; local_wl_from(0.00)[freebsd.org]; NEURAL_SPAM_LONG(0.76)[0.762,0]; NEURAL_SPAM_SHORT(0.10)[0.102,0]; NEURAL_SPAM_MEDIUM(0.81)[0.810,0] X-Rspamd-Server: mx1.freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Nov 2018 13:45:14 -0000 On Thu, Apr 04, 2013 at 11:19:52PM +0000, Steven Hartland wrote: > New Revision: 249115 > URL: http://svnweb.freebsd.org/changeset/base/249115 > > Log: > Adds security options to camcontrol this includes the ability to secure > erase disks such as SSD's > > Adds the ability to run ATA commands via the SCSI ATA Pass-Through(16) > com[m]and > > Modified: head/sbin/camcontrol/camcontrol.c > > [...] > +static int > +ata_do_identify(struct cam_device *device, int retry_count, int timeout, > + union ccb *ccb, struct ata_params** ident_bufp) > +{ > [...] > + > + error = ata_do_28bit_cmd(device, > + ccb, > + /*retries*/retry_count, > + /*flags*/CAM_DIR_IN, > + /*protocol*/AP_PROTO_PIO_IN, > + /*tag_action*/MSG_SIMPLE_Q_TAG, > + /*command*/command, > + /*features*/0, > + /*lba*/0, > + /*sector_count*/(u_int8_t)sizeof(struct ata_params), This looks strange: sizeof(struct ata_params) is 512, but it is too wide for u_int8_t, so it would be truncated to zero. Should it be 1 (one) here instead for ATA_ATA_IDENTIFY command, since it normally returns some data which typically fits one sector (>=512 bytes)? > + /*data_ptr*/(u_int8_t *)ptr, > + /*dxfer_len*/sizeof(struct ata_params), > + /*timeout*/timeout ? timeout : 30 * 1000, > + /*quiet*/1); > > [...] > + error = ata_do_28bit_cmd(device, > + ccb, > + /*retries*/retry_count, > + /*flags*/CAM_DIR_IN, > + /*protocol*/AP_PROTO_PIO_IN, > + /*tag_action*/MSG_SIMPLE_Q_TAG, > + /*command*/retry_command, > + /*features*/0, > + /*lba*/0, > + /*sector_count*/(u_int8_t) > + sizeof(struct ata_params), Same here. > + /*data_ptr*/(u_int8_t *)ptr, > + /*dxfer_len*/sizeof(struct ata_params), > + /*timeout*/timeout ? timeout : 30 * 1000, > + /*quiet*/0); ./danfe