Date: Tue, 12 Oct 2021 12:09:39 +0200 From: Christoph Moench-Tegeder <cmt@burggraben.net> To: Neel Chauhan <nc@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 72913e45e14b - main - devel/newt: Update to 0.52.21 Message-ID: <YWVe43/CUtMrTUYl@elch.exwg.net> In-Reply-To: <202110112311.19BNBBFJ028307@gitrepo.freebsd.org> References: <202110112311.19BNBBFJ028307@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
## Neel Chauhan (nc@FreeBSD.org):
> devel/newt: Update to 0.52.21
How was this tested?
With PYTHON=ON (the default), configure fails with
checking for python versions... ./configure: 3839: Syntax error: ")" unexpected (expecting "fi")
as configure.ac changed and doesn't match the assumptions in
post-patch-PYTHON-on anymore (and as it's just REINPLACE_CMD and not a
proper patch, you'll get no warning on that). In any case, that post-patch
operation isn't even neccessary, according to configure.ac and my tests,
a simple "PYTHON_CONFIGURE_WITH=python=${PYTHON_VERSION}" in our Makefile
just does the job.
> --- a/devel/newt/files/patch-configure.ac
> +++ b/devel/newt/files/patch-configure.ac
> @@ -1,15 +1,6 @@
> ---- configure.ac.orig 2017-03-17 10:36:31 UTC
> +--- configure.ac.orig 2019-05-27 12:57:40 UTC
> +++ configure.ac
> -@@ -2,7 +2,7 @@ AC_INIT([newt_pr.h])
> -
> - PACKAGE=newt
> - VERSION=0.52.20
> --SONAME=0.52
> -+SONAME=52
And this breaks packaging and perhaps even usage: this changes the library
name and (as the variable names imply) the SONAME: old was
SONAME libnewt.so.52
and new is
SONAME libnewt.so.0.52
all the while that change was never mentioned in the commit message.
What the heck? This is not a competition "who has the most commits".
Regards,
Christoph
--
Spare Space
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YWVe43/CUtMrTUYl>