From owner-freebsd-mips@FreeBSD.ORG  Wed Feb 19 18:39:21 2014
Return-Path: <owner-freebsd-mips@FreeBSD.ORG>
Delivered-To: freebsd-mips@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 25D31D7D
 for <freebsd-mips@freebsd.org>; Wed, 19 Feb 2014 18:39:21 +0000 (UTC)
Received: from cdptpa-omtalb.mail.rr.com (cdptpa-omtalb.mail.rr.com
 [75.180.132.120])
 by mx1.freebsd.org (Postfix) with ESMTP id D358D15F6
 for <freebsd-mips@freebsd.org>; Wed, 19 Feb 2014 18:39:20 +0000 (UTC)
X-Authority-Analysis: v=2.0 cv=GMaK45xK c=1 sm=0 a=Hbpc8ax9VmIgqBixU/K2CA==:17
 a=ByZx5UmUmsQA:10 a=dBRESv0yCI8A:10 a=ozSPa0bqj5AA:10 a=6I5d2MoRAAAA:8
 a=KGjhK52YXX0A:10 a=2p_r9YMhZi4A:10 a=7Qk2ozbKAAAA:8 a=K9Vg5clQmhdmQUSsdxcA:9
 a=CjuIK1q_8ugA:10 a=cvZW9r6VXHAA:10 a=SS5yS3T-GaTD-8OyLJEA:9
 a=_W_S_7VecoQA:10 a=v48euQvyAeMaH9YO:21 a=Hbpc8ax9VmIgqBixU/K2CA==:117
X-Cloudmark-Score: 0
X-Authenticated-User: 
X-Originating-IP: 76.187.139.93
Received: from [76.187.139.93] ([76.187.139.93:61616] helo=[192.168.0.22])
 by cdptpa-oedge01.mail.rr.com (envelope-from <sson@freebsd.org>)
 (ecelerity 2.2.3.46 r()) with ESMTP
 id 59/AC-00728-05AF4035; Wed, 19 Feb 2014 18:39:12 +0000
Mime-Version: 1.0 (Mac OS X Mail 6.6 \(1510\))
Subject: Re: [RFC] Enable use of UserLocal Register (ULRI) if detected
 (patches)
From: Stacey Son <sson@FreeBSD.org>
In-Reply-To: <092B0786-EA73-44D0-81FC-DFB56B14D4D7@bsdimp.com>
Date: Wed, 19 Feb 2014 12:39:12 -0600
Message-Id: <7FA7DFD1-B1F1-400A-9107-8D8450B309A2@FreeBSD.org>
References: <D964DBB1-3727-4B8A-B4E3-50FD8A300818@FreeBSD.org>
 <092B0786-EA73-44D0-81FC-DFB56B14D4D7@bsdimp.com>
To: Warner Losh <wlosh@bsdimp.com>
X-Mailer: Apple Mail (2.1510)
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: quoted-printable
X-Content-Filtered-By: Mailman/MimeDel 2.1.17
Cc: "freebsd-mips@freebsd.org" <freebsd-mips@freebsd.org>
X-BeenThere: freebsd-mips@freebsd.org
X-Mailman-Version: 2.1.17
Precedence: list
List-Id: Porting FreeBSD to MIPS <freebsd-mips.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-mips>,
 <mailto:freebsd-mips-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-mips/>
List-Post: <mailto:freebsd-mips@freebsd.org>
List-Help: <mailto:freebsd-mips-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-mips>,
 <mailto:freebsd-mips-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Feb 2014 18:39:21 -0000


On Feb 19, 2014, at 11:52 AM, Warner Losh <wlosh@bsdimp.com> wrote:

> +/* Register numbers */
> +#define	_V0	2
> +#define	_A1	5
> +#define	_T0	12
> +#define	_RA	31
>=20
> We already have defines for these registers elsewhere. Any reason why =
you chose not to use them? Also, is there any ABI difference to be =
worried about?

Hmm...  I missed these in sys/mips/include/regnum.h for some reason.  :)

> The rest looks generally good, apart from references to git versions =
that might be difficult to find in the future. Consider moving details =
inline instead.

That was really just a note to myself that I forgot to remove.

I have refreshed the patch with these changes:

http://people.freebsd.org/~sson/mips/ulri/ulri_kernel.diff


>> The final patch is for qemu system-mode that adds support for the =
ULRI:
>>=20
>> http://people.freebsd.org/~sson/mips/ulri/ulri_qemu.diff
>=20
> Can't say about these...

Qemu, like a lot of MIPS hardware it seems, doesn't support the ULRI.   =
The above is a just quick hack to qemu to add support as a 'FYI'.   I =
should maybe clean it up and submit it to the qemu development list.

-stacey.