From owner-svn-src-head@freebsd.org  Wed Jul  8 15:42:09 2015
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 8920E996240
 for <svn-src-head@mailman.ysv.freebsd.org>;
 Wed,  8 Jul 2015 15:42:09 +0000 (UTC)
 (envelope-from zbb@semihalf.com)
Received: from mail-wi0-f172.google.com (mail-wi0-f172.google.com
 [209.85.212.172])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (Client CN "smtp.gmail.com",
 Issuer "Google Internet Authority G2" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 399D11E64
 for <svn-src-head@freebsd.org>; Wed,  8 Jul 2015 15:42:09 +0000 (UTC)
 (envelope-from zbb@semihalf.com)
Received: by wiwl6 with SMTP id l6so348745210wiw.0
 for <svn-src-head@freebsd.org>; Wed, 08 Jul 2015 08:42:01 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20130820;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc:content-type;
 bh=csYl4zT2FiXMsQcRpu8cOqjUuWDAVg5vwnZMACAfyKw=;
 b=Z/vDgxp8tv1vJSzUu+gHS53Z5aEWdULLZgTJXHI3QVImIyidlHvuwFzOKlvn/cbbvw
 rTUTydgXJszuRcBK4l5+S+qVZMTs1YqDi8ARL+c1jti0QZ37Rxy/E9zhiEkaRI+N3cUw
 x1lmpdCFWmZDh54tpkIXPpXLmWhRxZ6VCUwoTSAjlBEWwi7ZVSQFMQWVc49TDD83dgnY
 QEudeptdo1EvClC5in23IkPVQJVESh2YxOcV4xPJjT0Ey8zINKpD/WQ+KbPzKvwcb/ZG
 1eidHjYHHjJZdW9axb0Bjh2EYpupv2FfVoUERnNJU1LrbGvdxKPjl/sXM8QxJkQU4Cli
 H+2g==
X-Gm-Message-State: ALoCoQk/+H+fsun8Xw8oIPCgycwzqcCwnvJ9Q/DVerepSqIzqAayNbqroy0ZPMgj3EP7gLFhlEuE
X-Received: by 10.194.59.98 with SMTP id y2mr21274756wjq.42.1436370121848;
 Wed, 08 Jul 2015 08:42:01 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.180.75.12 with HTTP; Wed, 8 Jul 2015 08:41:42 -0700 (PDT)
In-Reply-To: <201507081533.t68FX0Yb077433@repo.freebsd.org>
References: <201507081533.t68FX0Yb077433@repo.freebsd.org>
From: Zbigniew Bodek <zbb@semihalf.com>
Date: Wed, 8 Jul 2015 17:41:42 +0200
Message-ID: <CAG7dG+y80etMQgzOf28qwSh-t4pp3kx-kCGHEQRZbBUqWUDhsg@mail.gmail.com>
Subject: Re: svn commit: r285272 - head/sys/arm64/arm64
To: Andrew Turner <andrew@freebsd.org>
Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, 
 svn-src-head@freebsd.org
Content-Type: text/plain; charset=UTF-8
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Jul 2015 15:42:09 -0000

2015-07-08 17:33 GMT+02:00 Andrew Turner <andrew@freebsd.org>:
> Author: andrew
> Date: Wed Jul  8 15:32:59 2015
> New Revision: 285272
> URL: https://svnweb.freebsd.org/changeset/base/285272
>
> Log:
>   Add support for ipi_all_but_self on arm64.
>
>   Obtained from:        ABT Systems Ltd
>   Sponsored by: The freeBSD Foundation
>
> Modified:
>   head/sys/arm64/arm64/intr_machdep.c
>
> Modified: head/sys/arm64/arm64/intr_machdep.c
> ==============================================================================
> --- head/sys/arm64/arm64/intr_machdep.c Wed Jul  8 14:07:06 2015        (r285271)
> +++ head/sys/arm64/arm64/intr_machdep.c Wed Jul  8 15:32:59 2015        (r285272)
> @@ -48,6 +48,7 @@ __FBSDID("$FreeBSD$");
>  #include <sys/cpuset.h>
>  #include <sys/interrupt.h>
>  #include <sys/queue.h>
> +#include <sys/smp.h>
>
>  #include <machine/cpufunc.h>
>  #include <machine/intr.h>
> @@ -473,9 +474,16 @@ arm_init_secondary(void)
>  void
>  ipi_all_but_self(u_int ipi)
>  {
> +       cpuset_t other_cpus;
>
> -       /* ARM64TODO: We should support this */
> -       panic("ipi_all_but_self");
> +       other_cpus = all_cpus;
> +       CPU_CLR(PCPU_GET(cpuid), &other_cpus);
> +
> +       /* ARM64TODO: This will be fixed with arm_intrng */
> +       ipi += 16;

BTW. Can you explain why we need += 16 here?
We think this is wrong and we will probably try to upstream patches
that i.a. remove this.

Best regards
zbb

> +
> +       CTR2(KTR_SMP, "%s: ipi: %x", __func__, ipi);
> +       PIC_IPI_SEND(root_pic, other_cpus, ipi);
>  }
>
>  void
> _______________________________________________
> svn-src-all@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/svn-src-all
> To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"