From owner-svn-src-all@freebsd.org Tue Jan 29 17:28:59 2019 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2B33D14C4EC9; Tue, 29 Jan 2019 17:28:59 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 871FD90DD6; Tue, 29 Jan 2019 17:28:58 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pl1-x631.google.com with SMTP id u18so9640469plq.7; Tue, 29 Jan 2019 09:28:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=jzjVYJLJIiarPfNOy0TXSskJEkw1j8yXcXNN4W3h7/o=; b=Y6exSORDKxi3EiSOPAUslFKyfQ8RoDbSjjw7gxzjXh/gHARPpMTWpv4FZw/BGa27sZ zOT+Q3B8lq+f6uh3zaV4ClFnd5sV379mWUCbT73tC/LqctT4Dwys0k8IxLodfN7x1EH1 J1XJ6Q7x28MpdqzCNXl9CGrJFmakpUUhVtsuE+uD9o6TAT6tjpYuTg+wrLdwemyrhfZp D0pXwiAvCmZuvHLnZSKgAd5X2sikA8pL0XJ3+jhVzHRCt/CTnJbg7egFp3M4rNOKMF1e CEW8j2gaEqLPzlpdHVHrB3wr0x1v64tQZ4KyzPDL6I6Mcn4GqGFGx5Po4HaE3uCjEPdT oa3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=jzjVYJLJIiarPfNOy0TXSskJEkw1j8yXcXNN4W3h7/o=; b=IV9zAIwSZ4PRmFjt3CqzFZPxTB9Yfc6lKjCh1HbvTE2uxmgdEl3uBiibtkafddtaoj cLdKYy38I5WBFnt2pmuhnyLSDSoT+yx/KQMO3U3LxwK0ak1cdyfI+7ismCf047437Wqq gtMlmILwXNqLOyDi7UpQDSsTV6+6aX2Kz5BPlqg0dHWcogfWVBjUyaC85vsN5xLKQdHw g96HvwBczW5vrWNM4FYHqEcezG8HRlMPr7KzT+AqzxzkSX7h3cAtUdViSslSlXzFebhm d92OkcxzFC3c4uIdrxzgX2aCiREjjP1e4fN4pS/jZUFEiSc8frsoVBc4gs0f+YYKa0Ij NJ/w== X-Gm-Message-State: AJcUukczHV2g5PDKjT8uVm4qIdEKdBOUn4ReMTciy5js3J9WAG0tHrc9 qeXolguO3Xuf39bOnUmdrTNJoXdz X-Google-Smtp-Source: ALg8bN5Zpvzhf3nN0SN3593twkIj7sfBMkE7ta4uRTdbeShCDx5aeLPaFiM6UENHro0wLqHK2URCEA== X-Received: by 2002:a17:902:2c03:: with SMTP id m3mr25597382plb.6.1548782937101; Tue, 29 Jan 2019 09:28:57 -0800 (PST) Received: from [192.168.20.22] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id a90sm61375989pfj.109.2019.01.29.09.28.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Jan 2019 09:28:56 -0800 (PST) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (1.0) Subject: Re: svn commit: r343543 - head/sbin/bectl/tests From: Enji Cooper X-Mailer: iPhone Mail (16C104) In-Reply-To: <201901291706.x0TH6iKg009239@pdx.rh.CN85.dnsmgr.net> Date: Tue, 29 Jan 2019 09:28:55 -0800 Cc: Kyle Evans , src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: <84917F83-B4CD-4AD3-97EA-528366468880@gmail.com> References: <201901291706.x0TH6iKg009239@pdx.rh.CN85.dnsmgr.net> To: rgrimes@freebsd.org X-Rspamd-Queue-Id: 871FD90DD6 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.98 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.98)[-0.980,0] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Jan 2019 17:28:59 -0000 > On Jan 29, 2019, at 09:06, Rodney W. Grimes wrote: >=20 > [ Charset UTF-8 unsupported, converting... ] >> On Jan 28, 2019, at 20:31, Rodney W. Grimes wrote: >>=20 >>>>> On Mon, Jan 28, 2019 at 10:09 PM Kyle Evans wrote= : >>>>>=20 >>>>> Author: kevans >>>>> Date: Tue Jan 29 04:08:49 2019 >>>>> New Revision: 343543 >>>>> URL: https://svnweb.freebsd.org/changeset/base/343543 >>>>>=20 >>>>> Log: >>>>> bectl(8) test: Force destroy the zpool in cleanup >>>>>=20 >>>>> This is a wild guess as to why bectl tests failed once upon a time in C= I, >>>>> given no apparent way to see a transcript of cleanup routines with Kyu= a. The >>>>> bectl tests construct a new, clean zpool for every test. The failure >>>>> indicated was because of a mount that was leftover from a previous tes= t, but >>>>> the previous test had succeeded so it's not clear how the mount remain= ed >>>>> leftover unless the `zpool get health ${pool}` had somehow failed. >>>>>=20 >>>>=20 >>>> I left out: the tests are supposed to be constructed to clean up any >>>> mounts that were left over in the course of the test, hence the >>>> assumption that the failure lies in the cleanup. >>=20 >> Hi Rod, >>=20 >>> =46rom my experience as a hardware test engineer the test >>> setup was required to make sure any of those assumptions >>> are valid. Meaning that the test would have to validate >>> that no left over cruft was going to interfere with the >>> test about to be run. >>>=20 >>> Ie, you should probably do a force destroy of the pool >>> *before* the test too. >>=20 >> While this approach makes sense and is valid, it would leave open/orphane= d resources after each test run (in this case a single zpool). It?s best to f= ix the underlying issue with how the test formulates, sets up, and tears dow= n the zpool. >=20 > I did not advocate in any way that the post run cleanup > should be removed. Infact you should have both a pre-test > assurance that the environment is correct and a post-test > cleanup trying to removall all artifacts. >=20 > You can fix the current issue, but eventually if you get > enough testing going on your going to start to find that > things fail in ways that do not clean up (machine crash > is one instance) and not doing a pretest cleanup is eventually > going to run aground of this pitfall. I understand what you mean, but we don=E2=80=99t have to worry about this. O= ur CI runs don=E2=80=99t persist today as the bhyve instance is setup at sta= rt and torn down at exit (it was a problem in the first few iterations). Fur= thermore, resources like zpools that the bectl tests construct are should tr= ansient in nature at import (don=E2=80=99t affect the zpool.cache file), mea= ning that it should not be reconnected on the next boot. Assuming $TMPDIR is set to /tmp (or unset for that matter) and a standard rc= .conf configuration (or better yet, a tmpfs/md-backed filesystem), all lefto= ver remnants on disk will be cleaned up at next boot on test hosts that are m= ore persistent. Cheers, -Enji=