From owner-cvs-src@FreeBSD.ORG Thu May 20 16:45:27 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 8A4E116A4CE for ; Thu, 20 May 2004 16:45:27 -0700 (PDT) Received: from mail10.svc.cra.dublin.eircom.net (mail10.svc.cra.dublin.eircom.net [159.134.118.26]) by mx1.FreeBSD.org (Postfix) with SMTP id 0CF4C43D1D for ; Thu, 20 May 2004 16:45:27 -0700 (PDT) (envelope-from peadar@freebsd.org) Received: (qmail 31523 messnum 9212278 invoked from network[213.94.139.37/213-94-139-37.bas1.mvw.galway.eircom.net]); 20 May 2004 23:44:58 -0000 Received: from 213-94-139-37.bas1.mvw.galway.eircom.net (HELO freebsd.org) (213.94.139.37) by mail10.svc.cra.dublin.eircom.net (qp 31523) with SMTP; 20 May 2004 23:44:58 -0000 Message-ID: <40AD42E5.7050101@freebsd.org> Date: Fri, 21 May 2004 00:44:37 +0100 From: Peter Edwards User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.6) Gecko/20040424 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Nate Lawson References: <200405181653.i4IGrU6g062365@repoman.freebsd.org> In-Reply-To: <200405181653.i4IGrU6g062365@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit cc: cvs-src@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/acpica acpivar.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 May 2004 23:45:27 -0000 Hi Nate, This appears to be the cause of a boot-time panic for me, which for some reason only manifests itself when I've modules other than ACPI brought in by the loader (any of agp, vesa or snd_ich) Unlike the methods they replace, the __BUS_ACCESSOR methods from sys/bus.h don't seem to check the return code of BUS_READ_IVAR to return NULL on failure. The first few frames of the panic look like this (sorry, too early in the boot process for a dump: I can transcribe more if you need it) > AcpiNsWalkNamespace() + 0x53 (contrib/dev/acpica/nswalk.c:291) > AcpiWalkNamespace() + 0x47 (contrib/dev/acpica/nsxfeval.c:525) > acpi_pci_attach() At the site of the crash: > ChildType = ChildNode->Type The value of ChildNode appears to be 0xffffffff (taken from EAX), so it looks like that's what the __BUS_ACCESSOR method is returning for a failure. Rolling back the commit fixes the issue. Nate Lawson wrote: >njl 2004/05/18 09:53:29 PDT > > FreeBSD src repository > > Modified files: > sys/dev/acpica acpivar.h > Log: > Use the simpler __BUS_ACCESSOR macros for ivars instead of defining them > ourselves. > > Revision Changes Path > 1.65 +3 -56 src/sys/dev/acpica/acpivar.h > > >