From owner-freebsd-fs@FreeBSD.ORG  Fri Sep 17 18:49:41 2010
Return-Path: <owner-freebsd-fs@FreeBSD.ORG>
Delivered-To: freebsd-fs@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6ADFB1065672
	for <freebsd-fs@freebsd.org>; Fri, 17 Sep 2010 18:49:41 +0000 (UTC)
	(envelope-from mckusick@mckusick.com)
Received: from chez.mckusick.com (chez.mckusick.com [64.81.247.49])
	by mx1.freebsd.org (Postfix) with ESMTP id 34C878FC08
	for <freebsd-fs@freebsd.org>; Fri, 17 Sep 2010 18:49:40 +0000 (UTC)
Received: from chez.mckusick.com (localhost [127.0.0.1])
	by chez.mckusick.com (8.14.3/8.14.3) with ESMTP id o8HIneVw099913;
	Fri, 17 Sep 2010 11:49:40 -0700 (PDT)
	(envelope-from mckusick@chez.mckusick.com)
Message-Id: <201009171849.o8HIneVw099913@chez.mckusick.com>
To: obrien@freebsd.org
In-reply-to: <20100917180738.GA51572@dragon.NUXI.org> 
Date: Fri, 17 Sep 2010 11:49:40 -0700
From: Kirk McKusick <mckusick@mckusick.com>
Cc: freebsd-fs@freebsd.org
Subject: Re: [PATCH] replace INVARIANTS+panic() with KASSERT 
X-BeenThere: freebsd-fs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Filesystems <freebsd-fs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-fs>
List-Post: <mailto:freebsd-fs@freebsd.org>
List-Help: <mailto:freebsd-fs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-fs>,
	<mailto:freebsd-fs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 17 Sep 2010 18:49:41 -0000

> Date: Fri, 17 Sep 2010 11:07:38 -0700
> From: "David O'Brien" <obrien@freebsd.org>
> To: freebsd-fs@freebsd.org
> Subject: [PATCH] replace INVARIANTS+panic() with KASSERT
> 
> This patch changes most of the "asserts" and panic() within
> #ifdef INVARIANTS of olden years with KASSERTS.
> 
> In doing so, it also changes some '"%s: blah", "thing"' with just
> '"thing: blah"' to make grep'ing easier.
> 
> Some "notyet" code from the early 2000s is also reaped.
> 
> Some sysctls are also added to make it easier to change some diagnostics
> values at runtime vs. I believe using the debugger to change them.
> 
> thoughts?
> -- 
> -- David  (obrien@FreeBSD.org)
> 
> <<< patch followed >>>

Your changes look like a good step forward. Especially since most
folks do not include INVARIANTS these days expecting that KASSERTS
will cover them.

	Kirk McKusick