From owner-cvs-ports@FreeBSD.ORG Sat Jul 14 08:06:00 2012 Return-Path: Delivered-To: cvs-ports@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id F0446106566B; Sat, 14 Jul 2012 08:05:59 +0000 (UTC) (envelope-from matthew@FreeBSD.org) Received: from smtp.infracaninophile.co.uk (smtp6.infracaninophile.co.uk [IPv6:2001:8b0:151:1:3cd3:cd67:fafa:3d78]) by mx1.freebsd.org (Postfix) with ESMTP id 74A4E8FC16; Sat, 14 Jul 2012 08:05:59 +0000 (UTC) Received: from seedling.black-earth.co.uk (seedling.black-earth.co.uk [81.187.76.163]) (authenticated bits=0) by smtp.infracaninophile.co.uk (8.14.5/8.14.5) with ESMTP id q6E85su6048995 (version=TLSv1/SSLv3 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO); Sat, 14 Jul 2012 09:05:54 +0100 (BST) (envelope-from matthew@FreeBSD.org) X-DKIM: OpenDKIM Filter v2.5.2 smtp.infracaninophile.co.uk q6E85su6048995 Authentication-Results: smtp.infracaninophile.co.uk/q6E85su6048995; dkim=none (no signature); dkim-adsp=none Message-ID: <50012859.1080906@FreeBSD.org> Date: Sat, 14 Jul 2012 09:05:45 +0100 From: Matthew Seaman User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Alexey Dokuchaev References: <201207131023.q6DANo8l081040@repoman.freebsd.org> <20120714070300.GA55269@FreeBSD.org> <500120A8.700@yandex.ru> <20120714075126.GA62010@FreeBSD.org> In-Reply-To: <20120714075126.GA62010@FreeBSD.org> X-Enigmail-Version: 1.4.2 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig92BC51F435B748A8C28B4EF3" X-Virus-Scanned: clamav-milter 0.97.5 at lucid-nonsense.infracaninophile.co.uk X-Virus-Status: Clean X-Spam-Status: No, score=-2.7 required=5.0 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on lucid-nonsense.infracaninophile.co.uk Cc: Koop Mast , cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, Ruslan Mahmatkhanov , ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/games/gcompris Makefile distinfo pkg-descr pkg-plist X-BeenThere: cvs-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Jul 2012 08:06:00 -0000 This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig92BC51F435B748A8C28B4EF3 Content-Type: text/plain; charset=KOI8-R Content-Transfer-Encoding: quoted-printable On 14/07/2012 08:51, Alexey Dokuchaev wrote: > On Sat, Jul 14, 2012 at 11:32:56AM +0400, Ruslan Mahmatkhanov wrote: >> Alexey Dokuchaev wrote on 14.07.2012 11:03: >>> On Fri, Jul 13, 2012 at 10:23:50AM +0000, Koop Mast wrote: >>>> kwm 2012-07-13 10:23:50 UTC >>>> >>>> Modified files: >>>> games/gcompris Makefile distinfo pkg-descr pkg-plist >>>> Log: >>>> [...] >>>> Add tab in WWW line in pkg-descr. >>> >>> I think the last change takes us backwards: space is preferred separa= tor in >>> WWW: line of pkg-descr AFAICT. >> >> I always replace this space with a tab (in a manner as vars and values= =20 >> are separated in Makefile). Does it documented somewhere? And what the= =20 >> reason may be of space is preferable? Thanks. >=20 > Well, pkg-descr is not a Makefile. In makefiles, tabs help to align th= e > values nicely, as it helps readability a lot. On the contrary, pkg-des= cr is > mostly simple text, so there is not need to abuse tab here where single= > space perfectly suffices and IMHO looks a lot better. >=20 > Sadly, as with other stylish rather than functional issues, it does not= seem > to be documented. Hopefully after switch to SVN it would be easier to > isolate this kind of mechanical commits, and I will ask permission to > convert every port to single space + submit a patch to someone on doc@ = team > to be added to PH. Actually, it would make a lot of sense to take the WWW entries out of pkg-descr files entirely, and have them a variable in the main port Makefile instead. This would, at a stroke, reduce the number of files that need to be read to generate the INDEX by a factor of around 2, and consequentially speed things up. Cheers, Matthew --=20 Dr Matthew J Seaman MA, D.Phil. PGP: http://www.infracaninophile.co.uk/pgpkey --------------enig92BC51F435B748A8C28B4EF3 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG/MacGPG2 v2.0.16 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAlABKGIACgkQ8Mjk52CukIyerACfT+nN5u+A3jJD9Be5Alh6y76W 2MAAoJIH1EALPB0ZCzMlweLL3XkIgYxC =bMtK -----END PGP SIGNATURE----- --------------enig92BC51F435B748A8C28B4EF3--