From owner-freebsd-arch@FreeBSD.ORG Tue Feb 12 09:28:38 2013 Return-Path: Delivered-To: freebsd-arch@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id D7986D73 for ; Tue, 12 Feb 2013 09:28:38 +0000 (UTC) (envelope-from des@des.no) Received: from smtp.des.no (smtp.des.no [194.63.250.102]) by mx1.freebsd.org (Postfix) with ESMTP id 9BA38F7D for ; Tue, 12 Feb 2013 09:28:38 +0000 (UTC) Received: from ds4.des.no (smtp.des.no [194.63.250.102]) by smtp-int.des.no (Postfix) with ESMTP id C369C6568; Tue, 12 Feb 2013 09:28:37 +0000 (UTC) Received: by ds4.des.no (Postfix, from userid 1001) id 8D259A274; Tue, 12 Feb 2013 10:28:37 +0100 (CET) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Christoph Mallon Subject: Re: Proposal: Unify printing the function name in panic messages() References: <51141E33.4080103@gmx.de> <511426B8.2070800@FreeBSD.org> <51160E06.1070404@gmx.de> <20130209195417.C1753@besplex.bde.org> <51161C10.9070002@gmx.de> <5116504A.7010409@mu.org> <5118BEC9.1090708@gmx.de> Date: Tue, 12 Feb 2013 10:28:37 +0100 In-Reply-To: <5118BEC9.1090708@gmx.de> (Christoph Mallon's message of "Mon, 11 Feb 2013 10:50:01 +0100") Message-ID: <86bobphoe2.fsf@ds4.des.no> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Cc: Kirk McKusick , Alfred Perlstein , freebsd-arch@FreeBSD.org X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Feb 2013 09:28:38 -0000 Christoph Mallon writes: > Alfred Perlstein writes: > > Would we just turn panic() into a macro instead of making PANIC() > > everywhere in the kernel? Too many uppercase macros are hard on the > > eyes. > This is a good point. I will adjust the patches accordingly. Please don't. Macros need to be easily recognizable as such, since macro parameters are evaluated differently from function parameters. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@des.no