From owner-freebsd-ports-bugs@FreeBSD.ORG  Mon Jul 28 05:55:47 2014
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id A7573851
 for <freebsd-ports-bugs@FreeBSD.org>; Mon, 28 Jul 2014 05:55:47 +0000 (UTC)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 8F3F82047
 for <freebsd-ports-bugs@FreeBSD.org>; Mon, 28 Jul 2014 05:55:47 +0000 (UTC)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.14.8/8.14.8) with ESMTP id s6S5tlel024012
 for <freebsd-ports-bugs@FreeBSD.org>; Mon, 28 Jul 2014 05:55:47 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-ports-bugs@FreeBSD.org
Subject: [Bug 192177] [patch] unbreak audio/umurmur after devel/protobuf-c
 upgrade to version 1.0.0
Date: Mon, 28 Jul 2014 05:55:47 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Ports Tree
X-Bugzilla-Component: Individual Port(s)
X-Bugzilla-Version: Latest
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Some People
X-Bugzilla-Who: marino@FreeBSD.org
X-Bugzilla-Status: Patch Ready
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_status cc
Message-ID: <bug-192177-13-3n5H9z2I8Y@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-192177-13@https.bugs.freebsd.org/bugzilla/>
References: <bug-192177-13@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 28 Jul 2014 05:55:47 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192177

John Marino <marino@FreeBSD.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Triage                |Patch Ready
                 CC|                            |marino@FreeBSD.org

--- Comment #3 from John Marino <marino@FreeBSD.org> ---
Don, FYI the way you are providing changes is not committer friendly.  IIUC,
you provided 3 patches, but they are actually the contents of patches that need
to go in the files subdirectory.  So you are asking somebody to download each
patch, rename it to patch-<path-to-final-file-whatever-they-want>, move it to
files, and potentially revbump.

What committers expect is a single diff that creates the patches in files and
makes any necessary changes to the other files (e.g. Makefile, pkg-plist, etc).
 In other words, one diff that makes all the necessary changes to update the
port.

So if you make maintenance harder (unnecessarily), the volunteer committer may
just move on looking for an easier PR to knock out.

I'm just letting you know because I assume you didn't realize that your
approach wasn't friendly.

-- 
You are receiving this mail because:
You are the assignee for the bug.